Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: infra/bots/recipes/swarm_perf.py

Issue 2398173002: Disable svgs on nanobench when running on Valgrind (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-NVIDIA_Shield-GPU-TegraX1-arm64-Debug-GN_Android_Vulkan.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/bots/recipes/swarm_perf.py
diff --git a/infra/bots/recipes/swarm_perf.py b/infra/bots/recipes/swarm_perf.py
index 56a067015bf1cd22533277cc93008d34576bc11f..d20704a112460a6e840bd44df82267779c00e458 100644
--- a/infra/bots/recipes/swarm_perf.py
+++ b/infra/bots/recipes/swarm_perf.py
@@ -44,7 +44,7 @@ TEST_BUILDERS = {
}
-import calendar
+import time
def nanobench_flags(bot):
@@ -190,11 +190,14 @@ def perf_steps(api):
'--undefok', # This helps branches that may not know new flags.
'-i', api.flavor.device_dirs.resource_dir,
'--skps', api.flavor.device_dirs.skp_dir,
- '--svgs', api.flavor.device_dirs.svg_dir,
'--images', api.flavor.device_path_join(
api.flavor.device_dirs.images_dir, 'nanobench'),
]
+ # Do not run svgs on Valgrind.
+ if 'Valgrind' not in api.vars.builder_name:
+ args.extend(['--svgs', api.flavor.device_dirs.svg_dir])
+
skip_flag = None
if api.vars.builder_cfg.get('cpu_or_gpu') == 'CPU':
skip_flag = '--nogpu'
@@ -206,7 +209,7 @@ def perf_steps(api):
if api.vars.upload_perf_results:
now = api.time.utcnow()
- ts = int(calendar.timegm(now.utctimetuple()))
+ ts = int(time.mktime(now.utctimetuple()))
json_path = api.flavor.device_path_join(
api.flavor.device_dirs.perf_data_dir,
'nanobench_%s_%d.json' % (api.vars.got_revision, ts))
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-NVIDIA_Shield-GPU-TegraX1-arm64-Debug-GN_Android_Vulkan.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698