Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2398113002: Fix more tests on windows bots (Closed)

Created:
4 years, 2 months ago by Brian Wilkerson
Modified:
4 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -123 lines) Patch
M pkg/analyzer/lib/src/dart/sdk/sdk.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/package_test.dart View 4 chunks +14 lines, -14 lines 0 comments Download
M pkg/analyzer/test/source/package_map_provider_test.dart View 8 chunks +17 lines, -11 lines 0 comments Download
M pkg/analyzer/test/source/package_map_resolver_test.dart View 5 chunks +30 lines, -24 lines 0 comments Download
M pkg/analyzer/test/source/sdk_ext_test.dart View 4 chunks +30 lines, -13 lines 2 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 22 chunks +78 lines, -58 lines 4 comments Download
M pkg/analyzer/test/src/source/source_resource_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years, 2 months ago (2016-10-06 16:36:41 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2398113002/diff/1/pkg/analyzer/test/source/sdk_ext_test.dart File pkg/analyzer/test/source/sdk_ext_test.dart (right): https://codereview.chromium.org/2398113002/diff/1/pkg/analyzer/test/source/sdk_ext_test.dart#newcode29 pkg/analyzer/test/source/sdk_ext_test.dart:29: .replaceAll('\\', '\\\\'); replaceAll(r'\', r'\\') would be a bit ...
4 years, 2 months ago (2016-10-06 16:55:38 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2398113002/diff/1/pkg/analyzer/test/source/sdk_ext_test.dart File pkg/analyzer/test/source/sdk_ext_test.dart (right): https://codereview.chromium.org/2398113002/diff/1/pkg/analyzer/test/source/sdk_ext_test.dart#newcode29 pkg/analyzer/test/source/sdk_ext_test.dart:29: .replaceAll('\\', '\\\\'); Done https://codereview.chromium.org/2398113002/diff/1/pkg/analyzer/test/src/context/builder_test.dart File pkg/analyzer/test/src/context/builder_test.dart (right): https://codereview.chromium.org/2398113002/diff/1/pkg/analyzer/test/src/context/builder_test.dart#newcode68 pkg/analyzer/test/src/context/builder_test.dart:68: ...
4 years, 2 months ago (2016-10-06 17:14:55 UTC) #4
Brian Wilkerson
4 years, 2 months ago (2016-10-06 17:21:06 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2328bef00be8f80289bea6b44ed23e7ad0010e08 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698