Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: pkg/analyzer/test/source/sdk_ext_test.dart

Issue 2398113002: Fix more tests on windows bots (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.test.source.sdk_ext_test; 5 library analyzer.test.source.sdk_ext_test;
6 6
7 import 'package:analyzer/file_system/file_system.dart'; 7 import 'package:analyzer/file_system/file_system.dart';
8 import 'package:analyzer/file_system/memory_file_system.dart'; 8 import 'package:analyzer/file_system/memory_file_system.dart';
9 import 'package:analyzer/source/sdk_ext.dart'; 9 import 'package:analyzer/source/sdk_ext.dart';
10 import 'package:path/path.dart';
10 import 'package:test_reflective_loader/test_reflective_loader.dart'; 11 import 'package:test_reflective_loader/test_reflective_loader.dart';
11 import 'package:unittest/unittest.dart'; 12 import 'package:unittest/unittest.dart';
12 13
13 import '../utils.dart'; 14 import '../utils.dart';
14 15
15 main() { 16 main() {
16 initializeTestEnvironment(); 17 initializeTestEnvironment();
17 defineReflectiveTests(SdkExtUriResolverTest); 18 defineReflectiveTests(SdkExtUriResolverTest);
18 } 19 }
19 20
20 @reflectiveTest 21 @reflectiveTest
21 class SdkExtUriResolverTest { 22 class SdkExtUriResolverTest {
22 MemoryResourceProvider resourceProvider; 23 MemoryResourceProvider resourceProvider;
23 24
24 void setUp() { 25 void setUp() {
26 String joinAndEscape(List<String> components) {
27 return resourceProvider.pathContext
28 .joinAll(components)
29 .replaceAll('\\', '\\\\');
scheglov 2016/10/06 16:55:38 replaceAll(r'\', r'\\') would be a bit easier to r
Brian Wilkerson 2016/10/06 17:14:55 Done
30 }
31
25 resourceProvider = new MemoryResourceProvider(); 32 resourceProvider = new MemoryResourceProvider();
26 resourceProvider.newFolder('/empty'); 33 resourceProvider.newFolder(resourceProvider.convertPath('/empty'));
27 resourceProvider.newFolder('/tmp'); 34 resourceProvider.newFolder(resourceProvider.convertPath('/tmp'));
28 resourceProvider.newFile( 35 resourceProvider.newFile(
29 '/tmp/_sdkext', 36 resourceProvider.convertPath('/tmp/_sdkext'),
30 r''' 37 '''
31 { 38 {
32 "dart:fox": "slippy.dart", 39 "dart:fox": "slippy.dart",
33 "dart:bear": "grizzly.dart", 40 "dart:bear": "grizzly.dart",
34 "dart:relative": "../relative.dart", 41 "dart:relative": "${joinAndEscape(['..', 'relative.dart'])}",
35 "dart:deep": "deep/directory/file.dart", 42 "dart:deep": "${joinAndEscape(['deep', 'directory', 'file.dart'])}",
36 "fart:loudly": "nomatter.dart" 43 "fart:loudly": "nomatter.dart"
37 }'''); 44 }''');
38 } 45 }
39 46
40 test_create_badJSON() { 47 test_create_badJSON() {
41 var resolver = new SdkExtUriResolver(null); 48 var resolver = new SdkExtUriResolver(null);
42 resolver.addSdkExt(r'''{{{,{{}}},}}''', null); 49 resolver.addSdkExt(r'''{{{,{{}}},}}''', null);
43 expect(resolver.length, equals(0)); 50 expect(resolver.length, equals(0));
44 } 51 }
45 52
46 test_create_noSdkExtPackageMap() { 53 test_create_noSdkExtPackageMap() {
47 var resolver = new SdkExtUriResolver({ 54 var resolver = new SdkExtUriResolver({
48 'fox': <Folder>[resourceProvider.getResource('/empty')] 55 'fox': <Folder>[
56 resourceProvider.getFolder(resourceProvider.convertPath('/empty'))
57 ]
49 }); 58 });
50 expect(resolver.length, equals(0)); 59 expect(resolver.length, equals(0));
51 } 60 }
52 61
53 test_create_nullPackageMap() { 62 test_create_nullPackageMap() {
54 var resolver = new SdkExtUriResolver(null); 63 var resolver = new SdkExtUriResolver(null);
55 expect(resolver.length, equals(0)); 64 expect(resolver.length, equals(0));
56 } 65 }
57 66
58 test_create_sdkExtPackageMap() { 67 test_create_sdkExtPackageMap() {
59 var resolver = new SdkExtUriResolver({ 68 var resolver = new SdkExtUriResolver({
60 'fox': <Folder>[resourceProvider.getResource('/tmp')] 69 'fox': <Folder>[
70 resourceProvider.newFolder(resourceProvider.convertPath('/tmp'))
71 ]
61 }); 72 });
62 // We have four mappings. 73 // We have four mappings.
63 expect(resolver.length, equals(4)); 74 expect(resolver.length, equals(4));
64 // Check that they map to the correct paths. 75 // Check that they map to the correct paths.
65 expect(resolver['dart:fox'], equals("/tmp/slippy.dart")); 76 expect(resolver['dart:fox'],
66 expect(resolver['dart:bear'], equals("/tmp/grizzly.dart")); 77 equals(resourceProvider.convertPath('/tmp/slippy.dart')));
67 expect(resolver['dart:relative'], equals("/relative.dart")); 78 expect(resolver['dart:bear'],
68 expect(resolver['dart:deep'], equals("/tmp/deep/directory/file.dart")); 79 equals(resourceProvider.convertPath('/tmp/grizzly.dart')));
80 expect(resolver['dart:relative'],
81 equals(resourceProvider.convertPath('/relative.dart')));
82 expect(resolver['dart:deep'],
83 equals(resourceProvider.convertPath('/tmp/deep/directory/file.dart')));
69 } 84 }
70 85
71 test_restoreAbsolute() { 86 test_restoreAbsolute() {
72 var resolver = new SdkExtUriResolver({ 87 var resolver = new SdkExtUriResolver({
73 'fox': <Folder>[resourceProvider.getResource('/tmp')] 88 'fox': <Folder>[
89 resourceProvider.newFolder(resourceProvider.convertPath('/tmp'))
90 ]
74 }); 91 });
75 var source = resolver.resolveAbsolute(Uri.parse('dart:fox')); 92 var source = resolver.resolveAbsolute(Uri.parse('dart:fox'));
76 expect(source, isNotNull); 93 expect(source, isNotNull);
77 // Restore source's uri. 94 // Restore source's uri.
78 var restoreUri = resolver.restoreAbsolute(source); 95 var restoreUri = resolver.restoreAbsolute(source);
79 expect(restoreUri, isNotNull); 96 expect(restoreUri, isNotNull);
80 // Verify that it is 'dart:fox'. 97 // Verify that it is 'dart:fox'.
81 expect(restoreUri.toString(), equals('dart:fox')); 98 expect(restoreUri.toString(), equals('dart:fox'));
82 expect(restoreUri.scheme, equals('dart')); 99 expect(restoreUri.scheme, equals('dart'));
83 expect(restoreUri.path, equals('fox')); 100 expect(restoreUri.path, equals('fox'));
84 } 101 }
85 } 102 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698