Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2398013002: Reflow comments in core/css/parser (Closed)

Created:
4 years, 2 months ago by rune
Modified:
4 years, 2 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reflow comments in core/css/parser R=timloh@chromium.org BUG=563793 Committed: https://crrev.com/d0909e12aaaf66534aee43edff36ed08e746e0cb Cr-Commit-Position: refs/heads/master@{#423482}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed weird border-style comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -133 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSParser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp View 1 11 chunks +37 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserMode.h View 3 chunks +15 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserMode.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserObserver.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserSelector.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserSelector.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserTokenRange.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserTokenRange.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 29 chunks +82 lines, -53 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 4 chunks +25 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSupportsParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSTokenizerTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp View 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
rune
ptal
4 years, 2 months ago (2016-10-06 07:12:24 UTC) #2
Timothy Loh
stamp lgtm https://codereview.chromium.org/2398013002/diff/1/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp File third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp (right): https://codereview.chromium.org/2398013002/diff/1/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp#newcode513 third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp:513: case CSSPropertyBorderTopStyle: // <border-style> This one is ...
4 years, 2 months ago (2016-10-06 07:21:01 UTC) #4
rune
https://codereview.chromium.org/2398013002/diff/1/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp File third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp (right): https://codereview.chromium.org/2398013002/diff/1/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp#newcode513 third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp:513: case CSSPropertyBorderTopStyle: // <border-style> On 2016/10/06 07:21:01, Timothy Loh ...
4 years, 2 months ago (2016-10-06 07:36:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398013002/20001
4 years, 2 months ago (2016-10-06 07:36:45 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 09:03:51 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 09:06:52 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d0909e12aaaf66534aee43edff36ed08e746e0cb
Cr-Commit-Position: refs/heads/master@{#423482}

Powered by Google App Engine
This is Rietveld 408576698