Reflow comments in core/css/parser

third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/parser/CSSParserFastPaths.h"
 
 #include "core/StylePropertyShorthand.h"
 #include "core/css/CSSColorValue.h"
 #include "core/css/CSSFunctionValue.h"
 #include "core/css/CSSIdentifierValue.h"
@@ skipping 492 matching lines @@
       return valueID == CSSValueAuto || valueID == CSSValueAlphabetic ||
              valueID == CSSValueBaseline || valueID == CSSValueMiddle ||
              (valueID >= CSSValueBeforeEdge && valueID <= CSSValueMathematical);
     case CSSPropertyAll:
       return false;                     // Only accepts css-wide keywords
     case CSSPropertyBackgroundRepeatX:  // repeat | no-repeat
     case CSSPropertyBackgroundRepeatY:  // repeat | no-repeat
       return valueID == CSSValueRepeat || valueID == CSSValueNoRepeat;
     case CSSPropertyBorderCollapse:  // collapse | separate
       return valueID == CSSValueCollapse || valueID == CSSValueSeparate;
-    case CSSPropertyBorderTopStyle:  // <border-style>
-    case CSSPropertyBorderRightStyle:  // Defined as: none | hidden | dotted | dashed |
-    case CSSPropertyBorderBottomStyle:  // solid | double | groove | ridge | inset | outset
+    case CSSPropertyBorderTopStyle:     // <border-style>

[Timothy Loh, 2016/10/06 07:21:01]

This one is weird, maybe move it to before the return?

[rune, 2016/10/06 07:36:06]

I just removed it completely.

+    case CSSPropertyBorderRightStyle:   // Defined as: none | hidden | dotted |
+                                        // dashed |
+    case CSSPropertyBorderBottomStyle:  // solid | double | groove | ridge |
+                                        // inset | outset
     case CSSPropertyBorderLeftStyle:
     case CSSPropertyWebkitBorderAfterStyle:
     case CSSPropertyWebkitBorderBeforeStyle:
     case CSSPropertyWebkitBorderEndStyle:
     case CSSPropertyWebkitBorderStartStyle:
     case CSSPropertyColumnRuleStyle:
       return valueID >= CSSValueNone && valueID <= CSSValueDouble;
     case CSSPropertyBoxSizing:
       return valueID == CSSValueBorderBox || valueID == CSSValueContentBox;
     case CSSPropertyBufferedRendering:
@@ skipping 11 matching lines @@
     case CSSPropertyColorInterpolation:
     case CSSPropertyColorInterpolationFilters:
       return valueID == CSSValueAuto || valueID == CSSValueSRGB ||
              valueID == CSSValueLinearRGB;
     case CSSPropertyColorRendering:
       return valueID == CSSValueAuto || valueID == CSSValueOptimizeSpeed ||
              valueID == CSSValueOptimizeQuality;
     case CSSPropertyDirection:  // ltr | rtl
       return valueID == CSSValueLtr || valueID == CSSValueRtl;
     case CSSPropertyDisplay:
-      // inline | block | list-item | inline-block | table |
-      // inline-table | table-row-group | table-header-group | table-footer-group | table-row |
-      // table-column-group | table-column | table-cell | table-caption | -webkit-box | -webkit-inline-box | none
-      // flex | inline-flex | -webkit-flex | -webkit-inline-flex | grid | inline-grid
+      // inline | block | list-item | inline-block | table | inline-table |
+      // table-row-group | table-header-group | table-footer-group | table-row |
+      // table-column-group | table-column | table-cell | table-caption |
+      // -webkit-box | -webkit-inline-box | none | flex | inline-flex |
+      // -webkit-flex | -webkit-inline-flex | grid | inline-grid
       return (valueID >= CSSValueInline && valueID <= CSSValueInlineFlex) ||
              valueID == CSSValueWebkitFlex ||
              valueID == CSSValueWebkitInlineFlex || valueID == CSSValueNone ||
              (RuntimeEnabledFeatures::cssGridLayoutEnabled() &&
               (valueID == CSSValueGrid || valueID == CSSValueInlineGrid));
     case CSSPropertyDominantBaseline:
-      // auto | use-script | no-change | reset-size | ideographic |
-      // alphabetic | hanging | mathematical | central | middle |
-      // text-after-edge | text-before-edge
+      // auto | use-script | no-change | reset-size | ideographic | alphabetic |
+      // hanging | mathematical | central | middle | text-after-edge |
+      // text-before-edge
       return valueID == CSSValueAuto || valueID == CSSValueAlphabetic ||
              valueID == CSSValueMiddle ||
              (valueID >= CSSValueUseScript && valueID <= CSSValueResetSize) ||
              (valueID >= CSSValueCentral && valueID <= CSSValueMathematical);
     case CSSPropertyEmptyCells:  // show | hide
       return valueID == CSSValueShow || valueID == CSSValueHide;
     case CSSPropertyFloat:  // left | right | none
       return valueID == CSSValueLeft || valueID == CSSValueRight ||
              valueID == CSSValueNone;
     case CSSPropertyFontStyle:  // normal | italic | oblique
       return valueID == CSSValueNormal || valueID == CSSValueItalic ||
              valueID == CSSValueOblique;
-    case CSSPropertyFontStretch:  // normal | ultra-condensed | extra-condensed | condensed | semi-condensed | semi-expanded | expanded | extra-expanded | ultra-expanded
+    case CSSPropertyFontStretch:  // normal | ultra-condensed | extra-condensed
+                                  // | condensed | semi-condensed |
+                                  // semi-expanded | expanded | extra-expanded |
+                                  // ultra-expanded
       return valueID == CSSValueNormal || (valueID >= CSSValueUltraCondensed &&
                                            valueID <= CSSValueUltraExpanded);
     case CSSPropertyImageRendering:  // auto | optimizeContrast | pixelated
       return valueID == CSSValueAuto ||
              valueID == CSSValueWebkitOptimizeContrast ||
              valueID == CSSValuePixelated;
     case CSSPropertyIsolation:  // auto | isolate
       return valueID == CSSValueAuto || valueID == CSSValueIsolate;
     case CSSPropertyListStylePosition:  // inside | outside
       return valueID == CSSValueInside || valueID == CSSValueOutside;
@@ skipping 14 matching lines @@
     case CSSPropertyOverflowAnchor:
       return valueID == CSSValueVisible || valueID == CSSValueNone ||
              valueID == CSSValueAuto;
     case CSSPropertyOverflowWrap:  // normal | break-word
     case CSSPropertyWordWrap:
       return valueID == CSSValueNormal || valueID == CSSValueBreakWord;
     case CSSPropertyOverflowX:  // visible | hidden | scroll | auto | overlay
       return valueID == CSSValueVisible || valueID == CSSValueHidden ||
              valueID == CSSValueScroll || valueID == CSSValueAuto ||
              valueID == CSSValueOverlay;
-    case CSSPropertyOverflowY:  // visible | hidden | scroll | auto | overlay | -webkit-paged-x | -webkit-paged-y
+    case CSSPropertyOverflowY:  // visible | hidden | scroll | auto | overlay |

[Timothy Loh, 2016/10/06 07:21:01]

We should really just delete the completely redundant comments, I might do it
after this lands.

+                                // -webkit-paged-x | -webkit-paged-y
       return valueID == CSSValueVisible || valueID == CSSValueHidden ||
              valueID == CSSValueScroll || valueID == CSSValueAuto ||
              valueID == CSSValueOverlay || valueID == CSSValueWebkitPagedX ||
              valueID == CSSValueWebkitPagedY;
     case CSSPropertyBreakAfter:
     case CSSPropertyBreakBefore:
       return valueID == CSSValueAuto || valueID == CSSValueAvoid ||
              valueID == CSSValueAvoidPage || valueID == CSSValuePage ||
              valueID == CSSValueLeft || valueID == CSSValueRight ||
              valueID == CSSValueRecto || valueID == CSSValueVerso ||
@@ skipping 17 matching lines @@
       return valueID == CSSValueNone || valueID == CSSValueBoth ||
              valueID == CSSValueHorizontal || valueID == CSSValueVertical ||
              valueID == CSSValueAuto;
     case CSSPropertyScrollBehavior:  // auto | smooth
       ASSERT(RuntimeEnabledFeatures::cssomSmoothScrollEnabled());
       return valueID == CSSValueAuto || valueID == CSSValueSmooth;
     case CSSPropertyShapeRendering:
       return valueID == CSSValueAuto || valueID == CSSValueOptimizeSpeed ||
              valueID == CSSValueCrispEdges ||
              valueID == CSSValueGeometricPrecision;
-    case CSSPropertySpeak:  // none | normal | spell-out | digits | literal-punctuation | no-punctuation
+    case CSSPropertySpeak:  // none | normal | spell-out | digits |
+                            // literal-punctuation | no-punctuation
       return valueID == CSSValueNone || valueID == CSSValueNormal ||
              valueID == CSSValueSpellOut || valueID == CSSValueDigits ||
              valueID == CSSValueLiteralPunctuation ||
              valueID == CSSValueNoPunctuation;
     case CSSPropertyStrokeLinejoin:
       return valueID == CSSValueMiter || valueID == CSSValueRound ||
              valueID == CSSValueBevel;
     case CSSPropertyStrokeLinecap:
       return valueID == CSSValueButt || valueID == CSSValueRound ||
              valueID == CSSValueSquare;
@@ skipping 17 matching lines @@
       // solid | double | dotted | dashed | wavy
       ASSERT(RuntimeEnabledFeatures::css3TextDecorationsEnabled());
       return valueID == CSSValueSolid || valueID == CSSValueDouble ||
              valueID == CSSValueDotted || valueID == CSSValueDashed ||
              valueID == CSSValueWavy;
     case CSSPropertyTextJustify:
       // auto | none | inter-word | distribute
       ASSERT(RuntimeEnabledFeatures::css3TextEnabled());
       return valueID == CSSValueInterWord || valueID == CSSValueDistribute ||
              valueID == CSSValueAuto || valueID == CSSValueNone;
-    case CSSPropertyTextOrientation:  // mixed | upright | sideways | sideways-right
+    case CSSPropertyTextOrientation:  // mixed | upright | sideways |
+                                      // sideways-right
       return valueID == CSSValueMixed || valueID == CSSValueUpright ||
              valueID == CSSValueSideways || valueID == CSSValueSidewaysRight;
     case CSSPropertyWebkitTextOrientation:
       return valueID == CSSValueSideways || valueID == CSSValueSidewaysRight ||
              valueID == CSSValueVerticalRight || valueID == CSSValueUpright;
     case CSSPropertyTextOverflow:  // clip | ellipsis
       return valueID == CSSValueClip || valueID == CSSValueEllipsis;
-    case CSSPropertyTextRendering:  // auto | optimizeSpeed | optimizeLegibility | geometricPrecision
+    case CSSPropertyTextRendering:  // auto | optimizeSpeed | optimizeLegibility
+                                    // | geometricPrecision
       return valueID == CSSValueAuto || valueID == CSSValueOptimizeSpeed ||
              valueID == CSSValueOptimizeLegibility ||
              valueID == CSSValueGeometricPrecision;
     case CSSPropertyTextTransform:  // capitalize | uppercase | lowercase | none
       return (valueID >= CSSValueCapitalize && valueID <= CSSValueLowercase) ||
              valueID == CSSValueNone;
     case CSSPropertyUnicodeBidi:
       return valueID == CSSValueNormal || valueID == CSSValueEmbed ||
              valueID == CSSValueBidiOverride ||
              valueID == CSSValueWebkitIsolate ||
@@ skipping 33 matching lines @@
       return valueID == CSSValueSingle || valueID == CSSValueMultiple;
     case CSSPropertyWebkitBoxOrient:
       return valueID == CSSValueHorizontal || valueID == CSSValueVertical ||
              valueID == CSSValueInlineAxis || valueID == CSSValueBlockAxis;
     case CSSPropertyWebkitBoxPack:
       return valueID == CSSValueStart || valueID == CSSValueEnd ||
              valueID == CSSValueCenter || valueID == CSSValueJustify;
     case CSSPropertyColumnFill:
       return valueID == CSSValueAuto || valueID == CSSValueBalance;
     case CSSPropertyAlignContent:
-      // FIXME: Per CSS alignment, this property should accept an optional <overflow-position>. We should share this parsing code with 'justify-self'.
+      // FIXME: Per CSS alignment, this property should accept an optional
+      // <overflow-position>. We should share this parsing code with
+      // 'justify-self'.
       return valueID == CSSValueFlexStart || valueID == CSSValueFlexEnd ||
              valueID == CSSValueCenter || valueID == CSSValueSpaceBetween ||
              valueID == CSSValueSpaceAround || valueID == CSSValueStretch;
     case CSSPropertyAlignItems:
-      // FIXME: Per CSS alignment, this property should accept the same arguments as 'justify-self' so we should share its parsing code.
+      // FIXME: Per CSS alignment, this property should accept the same
+      // arguments as 'justify-self' so we should share its parsing code.
       return valueID == CSSValueFlexStart || valueID == CSSValueFlexEnd ||
              valueID == CSSValueCenter || valueID == CSSValueBaseline ||
              valueID == CSSValueStretch;
     case CSSPropertyAlignSelf:
-      // FIXME: Per CSS alignment, this property should accept the same arguments as 'justify-self' so we should share its parsing code.
+      // FIXME: Per CSS alignment, this property should accept the same
+      // arguments as 'justify-self' so we should share its parsing code.
       return valueID == CSSValueAuto || valueID == CSSValueFlexStart ||
              valueID == CSSValueFlexEnd || valueID == CSSValueCenter ||
              valueID == CSSValueBaseline || valueID == CSSValueStretch;
     case CSSPropertyFlexDirection:
       return valueID == CSSValueRow || valueID == CSSValueRowReverse ||
              valueID == CSSValueColumn || valueID == CSSValueColumnReverse;
     case CSSPropertyFlexWrap:
       return valueID == CSSValueNowrap || valueID == CSSValueWrap ||
              valueID == CSSValueWrapReverse;
     case CSSPropertyHyphens:
 #if OS(ANDROID) || OS(MACOSX)
       return valueID == CSSValueAuto || valueID == CSSValueNone ||
              valueID == CSSValueManual;
 #else
       return valueID == CSSValueNone || valueID == CSSValueManual;
 #endif
     case CSSPropertyJustifyContent:
-      // FIXME: Per CSS alignment, this property should accept an optional <overflow-position>. We should share this parsing code with 'justify-self'.
+      // FIXME: Per CSS alignment, this property should accept an optional
+      // <overflow-position>. We should share this parsing code with
+      // 'justify-self'.
       return valueID == CSSValueFlexStart || valueID == CSSValueFlexEnd ||
              valueID == CSSValueCenter || valueID == CSSValueSpaceBetween ||
              valueID == CSSValueSpaceAround;
     case CSSPropertyFontKerning:
       return valueID == CSSValueAuto || valueID == CSSValueNormal ||
              valueID == CSSValueNone;
     case CSSPropertyWebkitFontSmoothing:
       return valueID == CSSValueAuto || valueID == CSSValueNone ||
              valueID == CSSValueAntialiased ||
              valueID == CSSValueSubpixelAntialiased;
-    case CSSPropertyWebkitLineBreak:  // auto | loose | normal | strict | after-white-space
+    case CSSPropertyWebkitLineBreak:  // auto | loose | normal | strict |
+                                      // after-white-space
       return valueID == CSSValueAuto || valueID == CSSValueLoose ||
              valueID == CSSValueNormal || valueID == CSSValueStrict ||
              valueID == CSSValueAfterWhiteSpace;
     case CSSPropertyWebkitMarginAfterCollapse:
     case CSSPropertyWebkitMarginBeforeCollapse:
     case CSSPropertyWebkitMarginBottomCollapse:
     case CSSPropertyWebkitMarginTopCollapse:
       return valueID == CSSValueCollapse || valueID == CSSValueSeparate ||
              valueID == CSSValueDiscard;
     case CSSPropertyWebkitPrintColorAdjust:
@@ skipping 25 matching lines @@
     case CSSPropertyWritingMode:
       return valueID == CSSValueHorizontalTb || valueID == CSSValueVerticalRl ||
              valueID == CSSValueVerticalLr || valueID == CSSValueLrTb ||
              valueID == CSSValueRlTb || valueID == CSSValueTbRl ||
              valueID == CSSValueLr || valueID == CSSValueRl ||
              valueID == CSSValueTb;
     case CSSPropertyWhiteSpace:  // normal | pre | nowrap
       return valueID == CSSValueNormal || valueID == CSSValuePre ||
              valueID == CSSValuePreWrap || valueID == CSSValuePreLine ||
              valueID == CSSValueNowrap;
-    case CSSPropertyWordBreak:  // normal | break-all | keep-all | break-word (this is a custom extension)
+    case CSSPropertyWordBreak:  // normal | break-all | keep-all | break-word
+                                // (this is a custom extension)
       return valueID == CSSValueNormal || valueID == CSSValueBreakAll ||
              valueID == CSSValueKeepAll || valueID == CSSValueBreakWord;
     case CSSPropertyScrollSnapType:  // none | mandatory | proximity
       ASSERT(RuntimeEnabledFeatures::cssScrollSnapPointsEnabled());
       return valueID == CSSValueNone || valueID == CSSValueMandatory ||
              valueID == CSSValueProximity;
     default:
       ASSERT_NOT_REACHED();
       return false;
   }
@@ skipping 367 matching lines @@
   if (isColorPropertyID(propertyID))
     return parseColor(string, parserMode);
   if (CSSValue* keyword = parseKeywordValue(propertyID, string, parserMode))
     return keyword;
   if (CSSValue* transform = parseSimpleTransform(propertyID, string))
     return transform;
   return nullptr;
 }
 
 }  // namespace blink