Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: chrome/browser/password_manager/password_form_manager.h

Issue 23980003: Save password functionality added to the save password bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_form_manager.h
diff --git a/chrome/browser/password_manager/password_form_manager.h b/chrome/browser/password_manager/password_form_manager.h
index 877729908a3cae9cd0c2c6adcad5cd15fed6e344..27560a85205e4359d5fbe48e80edbb4a0b688b2b 100644
--- a/chrome/browser/password_manager/password_form_manager.h
+++ b/chrome/browser/password_manager/password_form_manager.h
@@ -71,6 +71,18 @@ class PasswordFormManager : public PasswordStoreConsumer {
// the same thread!
bool HasCompletedMatching();
+ // Sets current password to be saved when ApplyEdits() is called. Will
+ // override a previous call to BlacklistPassword().
+ void SavePassword();
+
+ // Sets current password to be blacklisted when ApplyEdits() is called. Will
+ // override a previous call to SavePassword().
+ void BlacklistPassword();
+
+ // Persist changes from the latest call to either SavePassword() or
+ // BlacklistPassword().
+ void ApplyChange();
+
// Determines if the user opted to 'never remember' passwords for this form.
bool IsBlacklisted();
@@ -105,6 +117,8 @@ class PasswordFormManager : public PasswordStoreConsumer {
// A user opted to 'never remember' passwords for this form.
// Blacklist it so that from now on when it is seen we ignore it.
+
+ // TODO: Make this private once we switch to the new UI.
Peter Kasting 2013/09/09 18:19:02 Tiny nit: Remove the blank line above or add an em
npentrel 2013/09/09 22:08:34 Done.
void PermanentlyBlacklist();
// If the user has submitted observed_form_, provisionally hold on to
@@ -120,6 +134,8 @@ class PasswordFormManager : public PasswordStoreConsumer {
// Handles save-as-new or update of the form managed by this manager.
// Note the basic data of updated_credentials must match that of
// observed_form_ (e.g DoesManage(pending_credentials_) == true).
+
+ // TODO: Make this private once we switch to the new UI.
void Save();
// Call these if/when we know the form submission worked or failed.
@@ -291,6 +307,8 @@ class PasswordFormManager : public PasswordStoreConsumer {
ManagerAction manager_action_;
UserAction user_action_;
SubmitResult submit_result_;
+ bool should_save_password_;
+ bool should_blacklist_password_;
DISALLOW_COPY_AND_ASSIGN(PasswordFormManager);
};

Powered by Google App Engine
This is Rietveld 408576698