Save password functionality added to the save password bubble

chrome/browser/content_settings/tab_specific_content_settings.h

Index: chrome/browser/content_settings/tab_specific_content_settings.h
diff --git a/chrome/browser/content_settings/tab_specific_content_settings.h b/chrome/browser/content_settings/tab_specific_content_settings.h
index b4873b718a893e744818031e73c85cd4909da9bc..28943430d873e5126cd22ab7b8c597e752231822 100644
--- a/chrome/browser/content_settings/tab_specific_content_settings.h
+++ b/chrome/browser/content_settings/tab_specific_content_settings.h
@@ -222,8 +222,6 @@ class TabSpecificContentSettings
     return midi_usages_state_;
   }
 
-  void OnPasswordSubmitted(PasswordFormManager* form_to_save);
-
   // Call to indicate that there is a protocol handler pending user approval.
   void set_pending_protocol_handler(const ProtocolHandler& handler) {
     pending_protocol_handler_ = handler;
@@ -297,6 +295,14 @@ class TabSpecificContentSettings
   virtual void AppCacheAccessed(const GURL& manifest_url,
                                 bool blocked_by_policy) OVERRIDE;
 
+  // If user clicks on 'save password' this will have the password saved upon
+  // the next navigation.

[Peter Kasting, 2013/09/09 18:19:02]

Nit: These two comments are confusing.  "This will have <x> saved"?  Is that
trying to say that this causes the password to be saved?  Maybe something like:

Called when the user clicks a "save password" button.  Instructs |form_to_save_|
that it should save the password if possible when it is closed or navigated.

(I don't know if this is perfectly accurate, please edit as needed)

(2 places)

[npentrel, 2013/09/09 22:08:34]

Done.

+  bool PasswordAccepted();
+
+  // If user clicks on 'never save password for this site' this have the
+  // password blacklisted upon the next navigation.
+  bool PasswordFormBlacklisted();
+
   // Message handlers. Public for testing.
   void OnContentBlocked(ContentSettingsType type,
                         const std::string& resource_identifier);
@@ -336,6 +342,11 @@ class TabSpecificContentSettings
       const MediaStreamDevicesController::MediaStreamTypePermissionMap&
           request_permissions);
 
+  // This method is called to pass the |form_to_save| on a successful password
+  // submission. It also updates the status of the save password content
+  // setting.

[Peter Kasting, 2013/09/09 18:19:02]

Nit: I don't know what this comment means.  "...to pass the |form_to_save|" has
no object; pass it to what?  Also, unnecessary passive voice (also with comments
above and below this one).  Maybe:

Called when a form containing a password is submitted.  |form_to_save| is the
submitted form.  Saves or blacklists the password from this form as set by
<name[s] of method[s]>.

(Again, I don't know if this is perfectly accurate.)

[npentrel, 2013/09/09 22:08:34]

Done.

+  void OnPasswordSubmitted(PasswordFormManager* form_to_save);
+
   // There methods are called to update the status about MIDI access.
   void OnMIDISysExAccessed(const GURL& reqesting_origin);
   void OnMIDISysExAccessBlocked(const GURL& requesting_origin);
@@ -417,6 +428,10 @@ class TabSpecificContentSettings
   // stored here. http://crbug.com/259794
   GURL media_stream_access_origin_;
 
+  // The PasswordFormManager managing the form we're asking the user about,
+  // and should update as per the decision.
+  scoped_ptr<PasswordFormManager> form_to_save_;
+
   DISALLOW_COPY_AND_ASSIGN(TabSpecificContentSettings);
 };