Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2397963002: Reflow comments in //third_party/WebKit/Source/core/editing/commands (Closed)

Created:
4 years, 2 months ago by dcheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reflow comments in //third_party/WebKit/Source/core/editing/commands BUG=563793 Committed: https://crrev.com/a5d709a0105ad9fc825ec40edf0d28abaded87d6 Cr-Commit-Position: refs/heads/master@{#423458}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebase #

Patch Set 4 : rebase #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+972 lines, -659 lines) Patch
M third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp View 1 2 3 chunks +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 32 chunks +109 lines, -71 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp View 5 chunks +12 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 2 36 chunks +144 lines, -92 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp View 31 chunks +136 lines, -93 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DragAndDropCommand.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 24 chunks +60 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommandNames.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp View 1 2 3 4 8 chunks +28 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp View 4 chunks +19 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp View 1 11 chunks +60 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp View 14 chunks +48 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp View 4 chunks +27 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/RemoveCSSPropertyCommand.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 1 2 37 chunks +198 lines, -130 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.cpp View 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SmartReplaceCF.cpp View 1 chunk +5 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SmartReplaceICU.cpp View 1 chunk +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.h View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 19 chunks +60 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UnlinkCommand.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
dcheng
4 years, 2 months ago (2016-10-06 02:20:18 UTC) #5
yosin_UTC9
lgtm Thanks for doing this! And sorry for needing rebase...
4 years, 2 months ago (2016-10-06 05:12:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397963002/80001
4 years, 2 months ago (2016-10-06 05:31:32 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-06 06:55:23 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 06:57:14 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a5d709a0105ad9fc825ec40edf0d28abaded87d6
Cr-Commit-Position: refs/heads/master@{#423458}

Powered by Google App Engine
This is Rietveld 408576698