third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp - Issue 2397963002: Reflow comments in //third_party/WebKit/Source/core/editing/commands

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp

Issue 2397963002: Reflow comments in //third_party/WebKit/Source/core/editing/commands (Closed)

Patch Set: . Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.h ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp

index 239bf25bde3984668679bf0b269a5cb36d7a96e6..168868f1e7405f3b23d5f1d8e02850437f4701d3 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp

@@ -58,7 +58,8 @@ static void swapInNodePreservingAttributesAndChildren(

for (const auto& child : children)

newElement->appendChild(child);

- // FIXME: Fix this to send the proper MutationRecords when MutationObservers are present.

+ // FIXME: Fix this to send the proper MutationRecords when MutationObservers

+ // are present.

newElement->cloneDataFromElement(elementToReplace);

parentNode->removeChild(&elementToReplace, ASSERT_NO_EXCEPTION);