Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: chromeos/dbus/session_manager_client.h

Issue 2397863003: Move free disk space check to session_manager. (Closed)
Patch Set: Address comment. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/session_manager_client.h
diff --git a/chromeos/dbus/session_manager_client.h b/chromeos/dbus/session_manager_client.h
index ee142aad64cd384fafa03c44ef9c46683b5c2d7c..06c1b86332bc599a87fbc2cf0a91c1c557a39eef 100644
--- a/chromeos/dbus/session_manager_client.h
+++ b/chromeos/dbus/session_manager_client.h
@@ -233,10 +233,16 @@ class CHROMEOS_EXPORT SessionManagerClient : public DBusClient {
// blocks Android ACTION_BOOT_COMPLETED broadcast for 3rd party applications.
// Upon completion, invokes |callback| with the result; true on success, false
// on failure (either session manager failed to start an instance or session
- // manager can not be reached).
+ // manager can not be reached). On Failure, the error is passed to the second
Daniel Erat 2016/10/06 14:53:54 nit: s/Failure/failure/
hidehiko 2016/10/07 05:28:38 Acknowledged.
+ // argument of the callback. The error may be empty even on failure, if the
+ // reponse is not received at all. The error looks like, e.g.,
Daniel Erat 2016/10/06 14:53:53 nit: s/reponse/response/
hidehiko 2016/10/07 05:28:38 Acknowledged.
+ // "org.freedesktop.DBus.Error.ServiceUnknown".
+ // TODO(hidehiko): Replace "typedef" by "using".
+ typedef base::Callback<void(bool success, const std::string& error)>
Daniel Erat 2016/10/06 14:53:53 is there any reason you can't perform this TODO in
hidehiko 2016/10/07 05:28:38 Other "Callback"s defined above use typedef for no
+ StartArcInstanceCallback;
virtual void StartArcInstance(const cryptohome::Identification& cryptohome_id,
bool disable_boot_completed_broadcast,
- const ArcCallback& callback) = 0;
+ const StartArcInstanceCallback& callback) = 0;
// Asynchronously stops the ARC instance. Upon completion, invokes
// |callback| with the result; true on success, false on failure (either

Powered by Google App Engine
This is Rietveld 408576698