Move free disk space check to session_manager.

chromeos/dbus/session_manager_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_SESSION_MANAGER_CLIENT_H_
 #define CHROMEOS_DBUS_SESSION_MANAGER_CLIENT_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 215 matching lines @@
   // Asynchronously checks if starting the ARC instance is available.
   // The result of the operation is reported through |callback|.
   // If the operation fails, it is reported as unavailable.
   virtual void CheckArcAvailability(const ArcCallback& callback) = 0;
 
   // Asynchronously starts the ARC instance for the user whose cryptohome is
   // located by |cryptohome_id|.  Flag |disable_boot_completed_broadcast|
   // blocks Android ACTION_BOOT_COMPLETED broadcast for 3rd party applications.
   // Upon completion, invokes |callback| with the result; true on success, false
   // on failure (either session manager failed to start an instance or session
-  // manager can not be reached).
+  // manager can not be reached). On Failure, the error is passed to the second

[Daniel Erat, 2016/10/06 14:53:54]

nit: s/Failure/failure/

[hidehiko, 2016/10/07 05:28:38]

Acknowledged.

+  // argument of the callback. The error may be empty even on failure, if the
+  // reponse is not received at all. The error looks like, e.g.,

[Daniel Erat, 2016/10/06 14:53:53]

nit: s/reponse/response/

[hidehiko, 2016/10/07 05:28:38]

Acknowledged.

+  // "org.freedesktop.DBus.Error.ServiceUnknown".
+  // TODO(hidehiko): Replace "typedef" by "using".
+  typedef base::Callback<void(bool success, const std::string& error)>

[Daniel Erat, 2016/10/06 14:53:53]

is there any reason you can't perform this TODO in this change?

[hidehiko, 2016/10/07 05:28:38]

Other "Callback"s defined above use typedef for now, so I used typedef for
consistency in this CL.
Let me send another CL to replace all typedefs to usings to keep the CL's focus.

+      StartArcInstanceCallback;
   virtual void StartArcInstance(const cryptohome::Identification& cryptohome_id,
                                 bool disable_boot_completed_broadcast,
-                                const ArcCallback& callback) = 0;
+                                const StartArcInstanceCallback& callback) = 0;
 
   // Asynchronously stops the ARC instance.  Upon completion, invokes
   // |callback| with the result; true on success, false on failure (either
   // session manager failed to stop an instance or session manager can not be
   // reached).
   virtual void StopArcInstance(const ArcCallback& callback) = 0;
 
   // Prioritizes the ARC instance by removing cgroups restrictions that
   // session_manager applies to the instance by default. Upon completion,
   // invokes |callback| with the result; true on success, false on failure.
@@ skipping 24 matching lines @@
   // Create() should be used instead.
   SessionManagerClient();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(SessionManagerClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_SESSION_MANAGER_CLIENT_H_