Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2397773002: Do not commit. Bug issue in the form of a CL. (Closed)

Created:
4 years, 2 months ago by tandrii(chromium)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not commit. Bug issue in the form of a CL. BUG=648290 R=phajdan.jr@chromium.org,nodir@chromium.org

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M git_cl.py View 2 chunks +2 lines, -0 lines 5 comments Download

Messages

Total messages: 8 (4 generated)
tandrii(chromium)
4 years, 2 months ago (2016-10-05 14:40:50 UTC) #1
tandrii(chromium)
Nodir, PTAL https://codereview.chromium.org/2397773002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/2397773002/diff/1/git_cl.py#newcode358 git_cl.py:358: 'master': master, i mean this line. https://codereview.chromium.org/2397773002/diff/1/git_cl.py#newcode382 ...
4 years, 2 months ago (2016-10-10 15:15:35 UTC) #6
nodir
https://codereview.chromium.org/2397773002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/2397773002/diff/1/git_cl.py#newcode358 git_cl.py:358: 'master': master, On 2016/10/10 15:15:35, tandrii(chromium) wrote: > i ...
4 years, 2 months ago (2016-10-10 17:18:12 UTC) #7
tandrii(chromium)
4 years, 2 months ago (2016-10-10 17:25:46 UTC) #8
https://codereview.chromium.org/2397773002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2397773002/diff/1/git_cl.py#newcode358
git_cl.py:358: 'master': master,
On 2016/10/10 17:18:11, nodir wrote:
> On 2016/10/10 15:15:35, tandrii(chromium) wrote:
> > i mean this line.
> 
> IDK. There may be recipes that rely on master properties.

I see. Well, these recipes will be broken with LUCI then, so there is hope of
removing this some day.

Powered by Google App Engine
This is Rietveld 408576698