Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: git_cl.py

Issue 2397773002: Do not commit. Bug issue in the form of a CL. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index c2675730cc4fc9c92de43750eca680381a6384bd..ed0524854c43e918b7550c211f9d4c289ddc2079 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -354,6 +354,7 @@ def trigger_try_jobs(auth_config, changelist, options, masters, category):
'properties': {
'category': category,
'issue': issue,
+ # Nodir, do even need this thing? Can it be removed?
'master': master,
tandrii(chromium) 2016/10/10 15:15:35 i mean this line.
nodir 2016/10/10 17:18:11 IDK. There may be recipes that rely on master prop
tandrii(chromium) 2016/10/10 17:25:45 I see. Well, these recipes will be broken with LUC
'patch_project': issue_props['project'],
'patch_storage': 'rietveld',
@@ -377,6 +378,7 @@ def trigger_try_jobs(auth_config, changelist, options, masters, category):
'client_operation_id': str(uuid.uuid4()),
'tags': ['builder:%s' % builder,
'buildset:%s' % buildset,
+ # Nodir, do even need this thing? Can it be removed?
'master:%s' % master,
tandrii(chromium) 2016/10/10 15:15:35 and this line.
nodir 2016/10/10 17:18:11 same
'user_agent:git_cl_try']
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698