Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2397753003: Revert of [turbofan] inline %StringIteratorPrototype%.next in JSBuiltinReducer. (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] inline %StringIteratorPrototype%.next in JSBuiltinReducer. (patchset #12 id:210001 of https://codereview.chromium.org/2373983004/ ) Reason for revert: [Sheriff] Speculative revert for win dbg: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/5029 Or we have an infra problem. Manual build before seems fine: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/5030 Original issue's description: > [turbofan] inline %StringIteratorPrototype%.next in JSBuiltinReducer. > > Implement the logic for StringIterator.prototype.next in the JSBuiltinReducer in order to allow inlining when the receiver is a JS_STRING_ITERATOR_TYPE map, built ontop of the SimplifiedOperators StringCharCodeAt and the newly added StringFromCodePoint. > > Also introduces a new StringFromCodePoint simplified op which may be useful for other String builtins, such as String.fromCodePoint() > > BUG=v8:5388 > R=bmeurer@chromium.org, mstarzinger@chromium.org > > Committed: https://crrev.com/aed32e0f22353527993de8bceaf246fc744558f5 > Cr-Commit-Position: refs/heads/master@{#39994} TBR=bmeurer@chromium.org,mvstanton@chromium.org,caitp@igalia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5388 Committed: https://crrev.com/4e5a4d9352e7254b349216075d8dc37bf4ffa217 Cr-Commit-Position: refs/heads/master@{#39995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -451 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/code-stub-assembler.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/access-builder.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/compiler/effect-control-linearizer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +0 lines, -196 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 3 chunks +0 lines, -3 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 3 chunks +0 lines, -139 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/simplified-operator.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator.cc View 3 chunks +0 lines, -28 lines 0 comments Download
M src/compiler/typer.cc View 4 chunks +0 lines, -22 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -21 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Achenbach
Created Revert of [turbofan] inline %StringIteratorPrototype%.next in JSBuiltinReducer.
4 years, 2 months ago (2016-10-05 14:29:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397753003/1
4 years, 2 months ago (2016-10-05 14:29:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 14:29:41 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4e5a4d9352e7254b349216075d8dc37bf4ffa217 Cr-Commit-Position: refs/heads/master@{#39995}
4 years, 2 months ago (2016-10-05 14:29:56 UTC) #7
caitp
On 2016/10/05 14:29:56, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 2 months ago (2016-10-05 15:57:09 UTC) #8
Michael Achenbach
4 years, 2 months ago (2016-10-05 19:52:23 UTC) #9
Message was sent while issue was closed.
On 2016/10/05 15:57:09, caitp wrote:
> On 2016/10/05 14:29:56, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/4e5a4d9352e7254b349216075d8dc37bf4ffa217
> > Cr-Commit-Position: refs/heads/master@{#39995}
> 
> Based on
>
http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/...,
> it looks like the String Iterator CL was not responsible for these failures. I
> see that the tree has been reopened, is it safe to send a reland CL now?

Go ahead, or I guess you already did. Sorry for the trouble.

Powered by Google App Engine
This is Rietveld 408576698