Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: src/compiler/typer.cc

Issue 2397753003: Revert of [turbofan] inline %StringIteratorPrototype%.next in JSBuiltinReducer. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/simplified-operator.cc ('k') | src/compiler/verifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/typer.cc
diff --git a/src/compiler/typer.cc b/src/compiler/typer.cc
index 15bc6dfba24becd2388b947c295f72ebc44ad7bd..e33b7764567881f149e760262b26a9a58f2b1f87 100644
--- a/src/compiler/typer.cc
+++ b/src/compiler/typer.cc
@@ -295,7 +295,6 @@
static Type* ReferenceEqualTyper(Type*, Type*, Typer*);
static Type* StringFromCharCodeTyper(Type*, Typer*);
- static Type* StringFromCodePointTyper(Type*, Typer*);
Reduction UpdateType(Node* node, Type* current) {
if (NodeProperties::IsTyped(node)) {
@@ -1366,10 +1365,6 @@
case kStringToLowerCase:
case kStringToUpperCase:
return Type::String();
-
- case kStringIteratorNext:
- return Type::OtherObject();
-
// Array functions.
case kArrayIndexOf:
case kArrayLastIndexOf:
@@ -1556,19 +1551,6 @@
return Type::String();
}
-Type* Typer::Visitor::StringFromCodePointTyper(Type* type, Typer* t) {
- type = NumberToUint32(ToNumber(type, t), t);
- Factory* f = t->isolate()->factory();
- double min = type->Min();
- double max = type->Max();
- if (min == max) {
- uint32_t code = static_cast<uint32_t>(min) & String::kMaxUtf16CodeUnitU;
- Handle<String> string = f->LookupSingleCharacterStringFromCode(code);
- return Type::Constant(string, t->zone());
- }
- return Type::String();
-}
-
Type* Typer::Visitor::TypeStringCharCodeAt(Node* node) {
// TODO(bmeurer): We could do better here based on inputs.
return Type::Range(0, kMaxUInt16, zone());
@@ -1576,10 +1558,6 @@
Type* Typer::Visitor::TypeStringFromCharCode(Node* node) {
return TypeUnaryOp(node, StringFromCharCodeTyper);
-}
-
-Type* Typer::Visitor::TypeStringFromCodePoint(Node* node) {
- return TypeUnaryOp(node, StringFromCodePointTyper);
}
Type* Typer::Visitor::TypeCheckBounds(Node* node) {
« no previous file with comments | « src/compiler/simplified-operator.cc ('k') | src/compiler/verifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698