Ditch first run experience from Save Password Infobar

Ditch first run experience from Save Password Infobar

BUG=610950
Committed: https://crrev.com/98e7c5bf360fe1a0db8c3e808798b81c23d5f038
Cr-Commit-Position: refs/heads/master@{#427986}

[melandory, 2016-10-05 11:53:36]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 11:53:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 12:15:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 12:15:28]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[melandory, 2016-10-05 13:27:45]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 13:27:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[melandory, 2016-10-05 14:29:54]

melandory@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[melandory, 2016-10-05 14:29:55]

PTAL, thanks!

[commit-bot: I haz the power, 2016-10-05 14:45:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 14:45:42]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[gone, 2016-10-05 17:33:00]

lgtm

[vasilii, 2016-10-06 11:00:04]

vasilii@chromium.org changed reviewers:
+ vasilii@chromium.org

[vasilii, 2016-10-06 11:00:05]

You should drop kWasSavePrompFirstRunExperienceShown, 
RecordSavePromptFirstRunExperienceWasShown, 
ShouldShowSavePromptFirstRunExperience and
IDS_PASSWORD_MANAGER_SAVE_PROMPT_FIRST_RUN_EXPERIENCE

[melandory, 2016-10-26 09:56:14]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 09:56:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 10:06:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 10:06:21]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[melandory, 2016-10-26 10:46:19]

Patchset #3 (id:40001) has been deleted

[melandory, 2016-10-26 13:48:39]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 13:48:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 15:05:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 15:05:14]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[melandory, 2016-10-26 15:48:59]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 15:49:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 16:11:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 16:11:50]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[melandory, 2016-10-27 07:51:38]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 07:51:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 07:53:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 07:53:30]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[melandory, 2016-10-27 08:14:40]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 08:15:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 09:12:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 09:12:01]

Dry run: This issue passed the CQ dry run.

[melandory, 2016-10-27 09:13:25]

On 2016/10/06 11:00:05, vasilii wrote:
> You should drop kWasSavePrompFirstRunExperienceShown, 
> RecordSavePromptFirstRunExperienceWasShown, 
> ShouldShowSavePromptFirstRunExperience and
Some of the entities above are used not only in the Infobar, will take care
later in other CL.
> IDS_PASSWORD_MANAGER_SAVE_PROMPT_FIRST_RUN_EXPERIENCE
Fixed.

[melandory, 2016-10-27 09:13:29]

On 2016/10/06 11:00:05, vasilii wrote:
> You should drop kWasSavePrompFirstRunExperienceShown, 
> RecordSavePromptFirstRunExperienceWasShown, 
> ShouldShowSavePromptFirstRunExperience and
Some of the entities above are used not only in the Infobar, will take care
later in other CL.
> IDS_PASSWORD_MANAGER_SAVE_PROMPT_FIRST_RUN_EXPERIENCE
Fixed.

[vasilii, 2016-10-27 09:18:56]

chrome/app/generated_resources.grd LGTM

[melandory, 2016-10-27 09:58:22]

The CQ bit was checked by melandory@chromium.org

[melandory, 2016-10-27 09:58:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2397743002/#ps100001
(title: "get rid of unused web_contents_")

[commit-bot: I haz the power, 2016-10-27 09:58:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 10:04:06]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-10-27 10:05:39]

Description was changed from

==========
Ditch first run experience from Save Password Infobar

BUG=610950
==========

to

==========
Ditch first run experience from Save Password Infobar

BUG=610950

Committed: https://crrev.com/98e7c5bf360fe1a0db8c3e808798b81c23d5f038
Cr-Commit-Position: refs/heads/master@{#427986}
==========

[commit-bot: I haz the power, 2016-10-27 10:05:41]

Patchset 5 (id:??) landed as
https://crrev.com/98e7c5bf360fe1a0db8c3e808798b81c23d5f038
Cr-Commit-Position: refs/heads/master@{#427986}