Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc

Issue 2397743002: Ditch first run experience from Save Password Infobar (Closed)
Patch Set: get rid of unused web_contents_ Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc
diff --git a/chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc b/chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc
index d724e74b5bb1aab026c6d2a044b57ddaceee90d8..1614f4620ec082dce3e59c20b8fa166f34aaf38f 100644
--- a/chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc
+++ b/chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc
@@ -52,12 +52,10 @@ class TestSavePasswordInfobarDelegate : public SavePasswordInfoBarDelegate {
public:
TestSavePasswordInfobarDelegate(
content::WebContents* web_contents,
- std::unique_ptr<password_manager::PasswordFormManager> form_to_save,
- bool should_show_first_run_experience)
+ std::unique_ptr<password_manager::PasswordFormManager> form_to_save)
: SavePasswordInfoBarDelegate(web_contents,
std::move(form_to_save),
- true /* is_smartlock_branding_enabled */,
- should_show_first_run_experience) {}
+ true /* is_smartlock_branding_enabled */) {}
~TestSavePasswordInfobarDelegate() override {}
};
@@ -79,8 +77,7 @@ class SavePasswordInfoBarDelegateTest : public ChromeRenderViewHostTestHarness {
protected:
std::unique_ptr<ConfirmInfoBarDelegate> CreateDelegate(
std::unique_ptr<password_manager::PasswordFormManager>
- password_form_manager,
- bool should_show_first_run_experience);
+ password_form_manager);
password_manager::StubPasswordManagerClient client_;
password_manager::StubPasswordManagerDriver driver_;
@@ -114,12 +111,10 @@ SavePasswordInfoBarDelegateTest::CreateMockFormManager() {
std::unique_ptr<ConfirmInfoBarDelegate>
SavePasswordInfoBarDelegateTest::CreateDelegate(
std::unique_ptr<password_manager::PasswordFormManager>
- password_form_manager,
- bool should_show_first_run_experience) {
+ password_form_manager) {
std::unique_ptr<ConfirmInfoBarDelegate> delegate(
new TestSavePasswordInfobarDelegate(web_contents(),
- std::move(password_form_manager),
- should_show_first_run_experience));
+ std::move(password_form_manager)));
return delegate;
}
@@ -136,7 +131,7 @@ TEST_F(SavePasswordInfoBarDelegateTest, CancelTestCredentialSourceAPI) {
CreateMockFormManager());
EXPECT_CALL(*password_form_manager.get(), PermanentlyBlacklist());
std::unique_ptr<ConfirmInfoBarDelegate> infobar(
- CreateDelegate(std::move(password_form_manager), false));
+ CreateDelegate(std::move(password_form_manager)));
EXPECT_TRUE(infobar->Cancel());
}
@@ -146,36 +141,6 @@ TEST_F(SavePasswordInfoBarDelegateTest,
CreateMockFormManager());
EXPECT_CALL(*password_form_manager.get(), PermanentlyBlacklist());
std::unique_ptr<ConfirmInfoBarDelegate> infobar(
- CreateDelegate(std::move(password_form_manager), false));
+ CreateDelegate(std::move(password_form_manager)));
EXPECT_TRUE(infobar->Cancel());
}
-
-TEST_F(SavePasswordInfoBarDelegateTest,
- CheckResetOfPrefAfterFirstRunMessageWasShown) {
- using password_manager::CredentialSourceType;
- prefs()->SetBoolean(
- password_manager::prefs::kWasSavePrompFirstRunExperienceShown, false);
- std::unique_ptr<MockPasswordFormManager> password_form_manager(
- CreateMockFormManager());
- std::unique_ptr<ConfirmInfoBarDelegate> infobar(
- CreateDelegate(std::move(password_form_manager), true));
- EXPECT_TRUE(infobar->Cancel());
- infobar.reset();
- EXPECT_TRUE(prefs()->GetBoolean(
- password_manager::prefs::kWasSavePrompFirstRunExperienceShown));
-}
-
-TEST_F(SavePasswordInfoBarDelegateTest,
- CheckNoStateOfPrefChangeWhenNoFirstRunExperienceShown) {
- using password_manager::CredentialSourceType;
- prefs()->SetBoolean(
- password_manager::prefs::kWasSavePrompFirstRunExperienceShown, false);
- std::unique_ptr<MockPasswordFormManager> password_form_manager(
- CreateMockFormManager());
- std::unique_ptr<ConfirmInfoBarDelegate> infobar(
- CreateDelegate(std::move(password_form_manager), false));
- EXPECT_TRUE(infobar->Cancel());
- infobar.reset();
- EXPECT_FALSE(prefs()->GetBoolean(
- password_manager::prefs::kWasSavePrompFirstRunExperienceShown));
-}
« no previous file with comments | « chrome/browser/password_manager/save_password_infobar_delegate_android.cc ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698