third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines.py - Issue 2397573002: Don't track SCM changes in rebaseline commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines.py

Issue 2397573002: Don't track SCM changes in rebaseline commands. (Closed)

Patch Set: Update message and docstring for has_working_directory_changes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_mock.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines.py

index 0c5c7ad771c2ef423c5311794c7bc91c74711766..bd1a50576e933fe59b1063dc87f54d8b02b13656 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines.py

@@ -73,6 +73,6 @@ class AnalyzeBaselines(AbstractRebaseliningCommand):

_log.error("No port names match '%s'", options.platform)

return

self._port = tool.port_factory.get(port_names[0])

- self._baseline_optimizer = self._optimizer_class(tool, self._port, port_names, skip_scm_commands=False)

+ self._baseline_optimizer = self._optimizer_class(tool, self._port, port_names)

for test_name in self._port.tests(args):

self._analyze_baseline(options, test_name)