third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines.py - Issue 2397573002: Don't track SCM changes in rebaseline commands.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines.py

Issue 2397573002: Don't track SCM changes in rebaseline commands. (Closed)

Patch Set: Update message and docstring for has_working_directory_changes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_mock.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright (c) 2016 Google Inc. All rights reserved.	1 # Copyright (c) 2016 Google Inc. All rights reserved.

2 #	2 #

3 # Redistribution and use in source and binary forms, with or without	3 # Redistribution and use in source and binary forms, with or without

4 # modification, are permitted provided that the following conditions are	4 # modification, are permitted provided that the following conditions are

5 # met:	5 # met:

6 #	6 #

7 # * Redistributions of source code must retain the above copyright	7 # * Redistributions of source code must retain the above copyright

8 # notice, this list of conditions and the following disclaimer.	8 # notice, this list of conditions and the following disclaimer.

9 # * Redistributions in binary form must reproduce the above	9 # * Redistributions in binary form must reproduce the above

10 # copyright notice, this list of conditions and the following disclaimer	10 # copyright notice, this list of conditions and the following disclaimer

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66 self._write("%s: (no baselines found)" % name)	66 self._write("%s: (no baselines found)" % name)

67	67

68 def execute(self, options, args, tool):	68 def execute(self, options, args, tool):

69 self._tool = tool	69 self._tool = tool

70 self._baseline_suffix_list = options.suffixes.split(',')	70 self._baseline_suffix_list = options.suffixes.split(',')

71 port_names = tool.port_factory.all_port_names(options.platform)	71 port_names = tool.port_factory.all_port_names(options.platform)

72 if not port_names:	72 if not port_names:

73 _log.error("No port names match '%s'", options.platform)	73 _log.error("No port names match '%s'", options.platform)

74 return	74 return

75 self._port = tool.port_factory.get(port_names[0])	75 self._port = tool.port_factory.get(port_names[0])

76 self._baseline_optimizer = self._optimizer_class(tool, self._port, port_ names, skip_scm_commands=False)	76 self._baseline_optimizer = self._optimizer_class(tool, self._port, port_ names)

77 for test_name in self._port.tests(args):	77 for test_name in self._port.tests(args):

78 self._analyze_baseline(options, test_name)	78 self._analyze_baseline(options, test_name)

OLD	NEW