Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2523)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2397373005: Catch empty PageStates on history navigations earlier. (Closed)
Patch Set: Remove page ID check. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 018ceadd69b3f87b97c45c20cb4c8fce1574ac5f..f801c639cfc7e89140a4194cb94d58e9687c94fa 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -5690,13 +5690,6 @@ void RenderFrameImpl::NavigateInternal(
GetWebHTTPBodyForRequestBody(common_params.post_data));
}
- // A session history navigation should have been accompanied by state.
- // TODO(creis): This is known to be failing in UseSubframeNavigationEntries
- // in https://crbug.com/568703, when the PageState on a FrameNavigationEntry
- // is unexpectedly empty. Until the cause is found, keep this as a DCHECK
- // and load the URL without PageState.
- DCHECK_EQ(request_params.page_id, -1);
-
should_load_request = true;
}
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698