Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 2397373005: Catch empty PageStates on history navigations earlier. (Closed)
Patch Set: Remove page ID check. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 5672 matching lines...) Expand 10 before | Expand all | Expand 10 after
5683 WebString::fromUTF8(i.values())); 5683 WebString::fromUTF8(i.values()));
5684 } 5684 }
5685 } 5685 }
5686 5686
5687 if (common_params.method == "POST" && !browser_side_navigation && 5687 if (common_params.method == "POST" && !browser_side_navigation &&
5688 common_params.post_data) { 5688 common_params.post_data) {
5689 request.setHTTPBody( 5689 request.setHTTPBody(
5690 GetWebHTTPBodyForRequestBody(common_params.post_data)); 5690 GetWebHTTPBodyForRequestBody(common_params.post_data));
5691 } 5691 }
5692 5692
5693 // A session history navigation should have been accompanied by state.
5694 // TODO(creis): This is known to be failing in UseSubframeNavigationEntries
5695 // in https://crbug.com/568703, when the PageState on a FrameNavigationEntry
5696 // is unexpectedly empty. Until the cause is found, keep this as a DCHECK
5697 // and load the URL without PageState.
5698 DCHECK_EQ(request_params.page_id, -1);
5699
5700 should_load_request = true; 5693 should_load_request = true;
5701 } 5694 }
5702 5695
5703 if (should_load_request) { 5696 if (should_load_request) {
5704 // PlzNavigate: check if the navigation being committed originated as a 5697 // PlzNavigate: check if the navigation being committed originated as a
5705 // client redirect. 5698 // client redirect.
5706 bool is_client_redirect = 5699 bool is_client_redirect =
5707 browser_side_navigation 5700 browser_side_navigation
5708 ? !!(common_params.transition & ui::PAGE_TRANSITION_CLIENT_REDIRECT) 5701 ? !!(common_params.transition & ui::PAGE_TRANSITION_CLIENT_REDIRECT)
5709 : false; 5702 : false;
(...skipping 720 matching lines...) Expand 10 before | Expand all | Expand 10 after
6430 // event target. Potentially a Pepper plugin will receive the event. 6423 // event target. Potentially a Pepper plugin will receive the event.
6431 // In order to tell whether a plugin gets the last mouse event and which it 6424 // In order to tell whether a plugin gets the last mouse event and which it
6432 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets 6425 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
6433 // the event, it will notify us via DidReceiveMouseEvent() and set itself as 6426 // the event, it will notify us via DidReceiveMouseEvent() and set itself as
6434 // |pepper_last_mouse_event_target_|. 6427 // |pepper_last_mouse_event_target_|.
6435 pepper_last_mouse_event_target_ = nullptr; 6428 pepper_last_mouse_event_target_ = nullptr;
6436 #endif 6429 #endif
6437 } 6430 }
6438 6431
6439 } // namespace content 6432 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698