Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2397373005: Catch empty PageStates on history navigations earlier. (Closed)

Created:
4 years, 2 months ago by Charlie Reis
Modified:
4 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Catch empty PageStates on history navigations earlier. We want to track down why some history navigations have empty PageStates. Since page ID is being removed, move the check to the browser process where we can more easily tell if it's a history navigation. BUG=568703 TEST=DCHECKs in the browser process rather than the renderer. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/316964d484c3045c84ac6654995c01bfa251e123 Cr-Commit-Position: refs/heads/master@{#424024}

Patch Set 1 #

Patch Set 2 : Fix compile #

Patch Set 3 : Remove page ID check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M content/browser/frame_host/navigator_impl.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Charlie Reis
Avi: Can you take a look? This should let us keep a DCHECK for the ...
4 years, 2 months ago (2016-10-08 00:10:14 UTC) #13
Charlie Reis
On 2016/10/08 00:10:14, Charlie Reis (Away till 10-14) wrote: > Avi: Can you take a ...
4 years, 2 months ago (2016-10-08 00:10:46 UTC) #14
Avi (use Gerrit)
lgtm
4 years, 2 months ago (2016-10-08 00:14:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397373005/40001
4 years, 2 months ago (2016-10-08 00:14:55 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-08 00:21:01 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 00:23:38 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/316964d484c3045c84ac6654995c01bfa251e123
Cr-Commit-Position: refs/heads/master@{#424024}

Powered by Google App Engine
This is Rietveld 408576698