Catch empty PageStates on history navigations earlier.

Catch empty PageStates on history navigations earlier.

We want to track down why some history navigations have empty
PageStates.  Since page ID is being removed, move the check to the
browser process where we can more easily tell if it's a history
navigation.

BUG=568703
TEST=DCHECKs in the browser process rather than the renderer.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/316964d484c3045c84ac6654995c01bfa251e123
Cr-Commit-Position: refs/heads/master@{#424024}

[Charlie Reis, 2016-10-07 22:04:59]

Description was changed from

==========
Catch empty PageStates on history navigations earlier.

We want to track down why some history navigations have empty
PageStates.  Since page ID is being removed, move the check to the
browser process where we can more easily tell if it's a history
navigation.

BUG=568703
TEST=DCHECKs in the browser process rather than the renderer.
==========

to

==========
Catch empty PageStates on history navigations earlier.

We want to track down why some history navigations have empty
PageStates.  Since page ID is being removed, move the check to the
browser process where we can more easily tell if it's a history
navigation.

BUG=568703
TEST=DCHECKs in the browser process rather than the renderer.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Charlie Reis, 2016-10-07 22:14:21]

The CQ bit was checked by creis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 22:14:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 22:27:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 22:27:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Charlie Reis, 2016-10-07 22:48:16]

The CQ bit was checked by creis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 22:48:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2016-10-07 22:50:16]

The CQ bit was checked by creis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 22:50:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 23:38:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 23:38:26]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2016-10-08 00:10:14]

creis@chromium.org changed reviewers:
+ avi@chromium.org

[Charlie Reis, 2016-10-08 00:10:14]

Avi: Can you take a look?  This should let us keep a DCHECK for the "empty
PageState on history nav" case without depending on page ID, which unblocks your
CL(s) to remove page ID.

(PS2 moved the page ID check to the browser process and also included the new
index-based check, and neither failed in any try job.  They should be basically
equivalent, so I dropped the page ID check in PS3.)

[Charlie Reis, 2016-10-08 00:10:46]

On 2016/10/08 00:10:14, Charlie Reis (Away till 10-14) wrote:
> Avi: Can you take a look?  This should let us keep a DCHECK for the "empty
> PageState on history nav" case without depending on page ID, which unblocks
your
> CL(s) to remove page ID.
> 
> (PS2 moved the page ID check to the browser process and also included the new
> index-based check, and neither failed in any try job.  They should be
basically
> equivalent, so I dropped the page ID check in PS3.)

Oh, and feel free to CQ if you don't see any problems, since I'll be OOO Monday.

[Avi (use Gerrit), 2016-10-08 00:14:34]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-10-08 00:14:35]

lgtm

[commit-bot: I haz the power, 2016-10-08 00:14:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 00:21:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-08 00:23:37]

Description was changed from

==========
Catch empty PageStates on history navigations earlier.

We want to track down why some history navigations have empty
PageStates.  Since page ID is being removed, move the check to the
browser process where we can more easily tell if it's a history
navigation.

BUG=568703
TEST=DCHECKs in the browser process rather than the renderer.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Catch empty PageStates on history navigations earlier.

We want to track down why some history navigations have empty
PageStates.  Since page ID is being removed, move the check to the
browser process where we can more easily tell if it's a history
navigation.

BUG=568703
TEST=DCHECKs in the browser process rather than the renderer.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/316964d484c3045c84ac6654995c01bfa251e123
Cr-Commit-Position: refs/heads/master@{#424024}
==========

[commit-bot: I haz the power, 2016-10-08 00:23:38]

Patchset 3 (id:??) landed as
https://crrev.com/316964d484c3045c84ac6654995c01bfa251e123
Cr-Commit-Position: refs/heads/master@{#424024}