Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2397303002:
Fix build error due to conflicting changes. (Closed)
|
Created:
4 years, 2 months ago by Mircea Trofin Modified:
4 years, 2 months ago Reviewers:
bradnelson CC:
v8-reviews_googlegroups.com, Clemens Hammacher Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionFix build error due to conflicting changes.
Strongly typing module_bytes needs a patch for the
serialization code.
Serialization bypasses module bytes, so their presence can't
be compulsory.
BUG=
Committed: https://crrev.com/b1fb83d58a6565712ccfcca2f453dfae0363b3ab
Cr-Commit-Position: refs/heads/master@{#40063}
Patch Set 1 #Patch Set 2 : remove bytes check from validation of wasm module object #
Messages
Total messages: 21 (16 generated)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix build error due to conflicting changes. BUG= ========== to ========== Fix build error due to conflicting changes. Strongly typing module_bytes needs a patch for the serialization code. BUG= ==========
mtrofin@chromium.org changed reviewers: + bradnelson@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/10321) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix build error due to conflicting changes. Strongly typing module_bytes needs a patch for the serialization code. BUG= ========== to ========== Fix build error due to conflicting changes. Strongly typing module_bytes needs a patch for the serialization code. Serialization bypasses module bytes, so their presence can't be compulsory. BUG= ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mtrofin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bradnelson@chromium.org Link to the patchset: https://codereview.chromium.org/2397303002/#ps20001 (title: "remove bytes check from validation of wasm module object")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix build error due to conflicting changes. Strongly typing module_bytes needs a patch for the serialization code. Serialization bypasses module bytes, so their presence can't be compulsory. BUG= ========== to ========== Fix build error due to conflicting changes. Strongly typing module_bytes needs a patch for the serialization code. Serialization bypasses module bytes, so their presence can't be compulsory. BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix build error due to conflicting changes. Strongly typing module_bytes needs a patch for the serialization code. Serialization bypasses module bytes, so their presence can't be compulsory. BUG= ========== to ========== Fix build error due to conflicting changes. Strongly typing module_bytes needs a patch for the serialization code. Serialization bypasses module bytes, so their presence can't be compulsory. BUG= ==========
Message was sent while issue was closed.
Description was changed from ========== Fix build error due to conflicting changes. Strongly typing module_bytes needs a patch for the serialization code. Serialization bypasses module bytes, so their presence can't be compulsory. BUG= ========== to ========== Fix build error due to conflicting changes. Strongly typing module_bytes needs a patch for the serialization code. Serialization bypasses module bytes, so their presence can't be compulsory. BUG= Committed: https://crrev.com/b1fb83d58a6565712ccfcca2f453dfae0363b3ab Cr-Commit-Position: refs/heads/master@{#40063} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b1fb83d58a6565712ccfcca2f453dfae0363b3ab Cr-Commit-Position: refs/heads/master@{#40063} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
