Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: src/api.cc

Issue 2397303002: Fix build error due to conflicting changes. (Closed)
Patch Set: remove bytes check from validation of wasm module object Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/wasm/wasm-module.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 6c23f6bdfd7a093da7f50e1ebde733cfd35bee13..6bb15d2e268a01eefff367e45a2eee5cdb823f6a 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -7189,7 +7189,8 @@ Local<String> WasmCompiledModule::GetUncompiledBytes() {
i::Handle<i::JSObject>::cast(Utils::OpenHandle(this));
i::Handle<i::wasm::WasmCompiledModule> compiled_part =
i::handle(i::wasm::WasmCompiledModule::cast(obj->GetInternalField(0)));
- return Local<String>::Cast(Utils::ToLocal(compiled_part->module_bytes()));
+ i::Handle<i::String> module_bytes = compiled_part->module_bytes();
+ return Local<String>::Cast(Utils::ToLocal(module_bytes));
}
WasmCompiledModule::SerializedModule WasmCompiledModule::Serialize() {
@@ -7198,7 +7199,8 @@ WasmCompiledModule::SerializedModule WasmCompiledModule::Serialize() {
i::Handle<i::wasm::WasmCompiledModule> compiled_part =
i::handle(i::wasm::WasmCompiledModule::cast(obj->GetInternalField(0)));
- i::Handle<i::String> uncompiled_bytes = compiled_part->module_bytes();
+ i::Handle<i::SeqOneByteString> uncompiled_bytes =
+ compiled_part->module_bytes();
compiled_part->reset_module_bytes();
std::unique_ptr<i::ScriptData> script_data =
i::WasmCompiledModuleSerializer::SerializeWasmModule(obj->GetIsolate(),
« no previous file with comments | « no previous file | src/wasm/wasm-module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698