Show a custom page info bubble for chrome-devtools:// URLs

chrome/browser/ui/website_settings/website_settings.cc

Index: chrome/browser/ui/website_settings/website_settings.cc
diff --git a/chrome/browser/ui/website_settings/website_settings.cc b/chrome/browser/ui/website_settings/website_settings.cc
index 914ce96d88e626900c329b620da2c5a75a58689a..bf44bbf8b40cc416a381b5a442b218579754b30c 100644
--- a/chrome/browser/ui/website_settings/website_settings.cc
+++ b/chrome/browser/ui/website_settings/website_settings.cc
@@ -399,6 +399,12 @@ void WebsiteSettings::Init(
   bool isChromeUINativeScheme = false;
 #if BUILDFLAG(ANDROID_JAVA_UI)
   isChromeUINativeScheme = url.SchemeIs(chrome::kChromeUINativeScheme);
+#else
+  // On desktop, internal URLs are displayed in a different UI and not here.

[elawrence, 2016/10/07 21:04:01]

Is "desktop" mutually exclusive with "ANDROID_JAVA_UI" (e.g. what about bling?)

[meacer, 2016/10/10 18:09:19]

Ah, ANDROID_JAVA_UI really confused me. I thought it was default on Android
builds, but apparently it's not and it's going to be removed soon. I moved the
check to above.

+  DCHECK(!url.SchemeIs(content::kChromeUIScheme) &&
+         !url.SchemeIs(content::kChromeDevToolsScheme) &&
+         !url.SchemeIs(content::kViewSourceScheme) &&
+         !url.SchemeIs(content_settings::kExtensionScheme));
 #endif
 
   if (url.SchemeIs(url::kAboutScheme)) {
@@ -414,7 +420,7 @@ void WebsiteSettings::Init(
     return;
   }
 
-  if (url.SchemeIs(content::kChromeUIScheme) || isChromeUINativeScheme) {
+  if (isChromeUINativeScheme) {

[elawrence, 2016/10/07 21:04:01]

I'm not sure I understand this change. Is this:

    url.SchemeIs(content::kChromeUIScheme) 

... not possible when ANDROID_JAVA_UI?

[meacer, 2016/10/10 18:09:19]

I was being overly aggressive here, reverted this change.

     site_identity_status_ = SITE_IDENTITY_STATUS_INTERNAL_PAGE;
     site_identity_details_ =
         l10n_util::GetStringUTF16(IDS_PAGE_INFO_INTERNAL_PAGE);