Show a custom page info bubble for chrome-devtools:// URLs

chrome/browser/ui/website_settings/website_settings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/website_settings/website_settings.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <string>
@@ skipping 381 matching lines @@
       site_url().host());
   did_revoke_user_ssl_decisions_ = true;
 }
 
 void WebsiteSettings::Init(
     const GURL& url,
     const SecurityStateModel::SecurityInfo& security_info) {
   bool isChromeUINativeScheme = false;
 #if BUILDFLAG(ANDROID_JAVA_UI)
   isChromeUINativeScheme = url.SchemeIs(chrome::kChromeUINativeScheme);
+#else
+  // On desktop, internal URLs are displayed in a different UI and not here.

[elawrence, 2016/10/07 21:04:01]

Is "desktop" mutually exclusive with "ANDROID_JAVA_UI" (e.g. what about bling?)

[meacer, 2016/10/10 18:09:19]

Ah, ANDROID_JAVA_UI really confused me. I thought it was default on Android
builds, but apparently it's not and it's going to be removed soon. I moved the
check to above.

+  DCHECK(!url.SchemeIs(content::kChromeUIScheme) &&
+         !url.SchemeIs(content::kChromeDevToolsScheme) &&
+         !url.SchemeIs(content::kViewSourceScheme) &&
+         !url.SchemeIs(content_settings::kExtensionScheme));
 #endif
 
   if (url.SchemeIs(url::kAboutScheme)) {
     // All about: URLs except about:blank are redirected.
     DCHECK_EQ(url::kAboutBlankURL, url.spec());
     site_identity_status_ = SITE_IDENTITY_STATUS_NO_CERT;
     site_identity_details_ =
         l10n_util::GetStringUTF16(IDS_PAGE_INFO_SECURITY_TAB_INSECURE_IDENTITY);
     site_connection_status_ = SITE_CONNECTION_STATUS_UNENCRYPTED;
     site_connection_details_ = l10n_util::GetStringFUTF16(
         IDS_PAGE_INFO_SECURITY_TAB_NOT_ENCRYPTED_CONNECTION_TEXT,
         UTF8ToUTF16(url.spec()));
     return;
   }
 
-  if (url.SchemeIs(content::kChromeUIScheme) || isChromeUINativeScheme) {
+  if (isChromeUINativeScheme) {

[elawrence, 2016/10/07 21:04:01]

I'm not sure I understand this change. Is this:

    url.SchemeIs(content::kChromeUIScheme) 

... not possible when ANDROID_JAVA_UI?

[meacer, 2016/10/10 18:09:19]

I was being overly aggressive here, reverted this change.

     site_identity_status_ = SITE_IDENTITY_STATUS_INTERNAL_PAGE;
     site_identity_details_ =
         l10n_util::GetStringUTF16(IDS_PAGE_INFO_INTERNAL_PAGE);
     site_connection_status_ = SITE_CONNECTION_STATUS_INTERNAL_PAGE;
     return;
   }
 
   // Identity section.
   certificate_ = security_info.certificate;
 
@@ skipping 370 matching lines @@
   info.connection_status = site_connection_status_;
   info.connection_status_description =
       UTF16ToUTF8(site_connection_details_);
   info.identity_status = site_identity_status_;
   info.identity_status_description =
       UTF16ToUTF8(site_identity_details_);
   info.certificate = certificate_;
   info.show_ssl_decision_revoke_button = show_ssl_decision_revoke_button_;
   ui_->SetIdentityInfo(info);
 }