Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.h

Issue 2397273002: Show a custom page info bubble for chrome-devtools:// URLs (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.h
diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
index 5f1d114b8ccbf6f739afba021231d7220304a0ac..c4006be6cdd179fd3a37677dc79a4c38eab8cd8b 100644
--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
@@ -64,6 +64,15 @@ class WebsiteSettingsPopupView : public content::WebContentsObserver,
public:
~WebsiteSettingsPopupView() override;
+ // Type of the popup being displayed.
+ enum PopupType {
+ POPUP_NONE,
+ // Usual page info bubble for websites.
+ POPUP_WEBSITE_SETTINGS,
+ // Custom bubble for internal pages like chrome:// and chrome-extensions://.
+ POPUP_INTERNAL_PAGE
+ };
+
// If |anchor_view| is null, |anchor_rect| is used to anchor the bubble.
static void ShowPopup(
views::View* anchor_view,
@@ -73,7 +82,8 @@ class WebsiteSettingsPopupView : public content::WebContentsObserver,
const GURL& url,
const security_state::SecurityStateModel::SecurityInfo& security_info);
- static bool IsPopupShowing();
+ // Returns the type of the popup bubble being shown.
+ static PopupType GetShownPopupType();
private:
friend class test::WebsiteSettingsPopupViewTestApi;

Powered by Google App Engine
This is Rietveld 408576698