Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1586)

Unified Diff: chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc

Issue 2397273002: Show a custom page info bubble for chrome-devtools:// URLs (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc
diff --git a/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc b/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc
index 83d8aafb8e002df6ce18e1b82843cc472537dcdc..ca23b00dd53f1a1782562ba0cb2ed1af840cd172 100644
--- a/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc
+++ b/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc
@@ -4,14 +4,12 @@
#include "chrome/browser/ui/views/location_bar/location_icon_view.h"
-#include "base/command_line.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/location_bar/location_bar_view.h"
#include "chrome/browser/ui/views/toolbar/toolbar_view.h"
#include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/interactive_test_utils.h"
-#include "ui/aura/window.h"
namespace {
@@ -34,7 +32,8 @@ IN_PROC_BROWSER_TEST_F(LocationIconViewTest, HideOnSecondClick) {
runner1->QuitClosure());
runner1->Run();
- EXPECT_TRUE(WebsiteSettingsPopupView::IsPopupShowing());
+ EXPECT_EQ(WebsiteSettingsPopupView::POPUP_WEBSITE_SETTINGS,
+ WebsiteSettingsPopupView::GetShownPopupType());
// Verify that clicking again doesn't reshow it.
scoped_refptr<content::MessageLoopRunner> runner2 =
@@ -46,7 +45,8 @@ IN_PROC_BROWSER_TEST_F(LocationIconViewTest, HideOnSecondClick) {
runner2->QuitClosure());
runner2->Run();
- EXPECT_FALSE(WebsiteSettingsPopupView::IsPopupShowing());
+ EXPECT_EQ(WebsiteSettingsPopupView::POPUP_NONE,
+ WebsiteSettingsPopupView::GetShownPopupType());
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698