Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2397053003:
[parser] Load outer ScopeInfo from SharedFunctionInfo. (Closed)
|
Created:
4 years, 2 months ago by Michael Starzinger Modified:
4 years, 2 months ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[parser] Load outer ScopeInfo from SharedFunctionInfo.
This switches the {ParseInfo} constructor to always determine the outer
scope info from the shared function info instead of a concrete closure.
It is a precursor to deprecate the constructor taking closures entirely
and hence make the fact that we can parse without a closure explicit.
R=jochen@chromium.org
BUG=v8:2206
Committed: https://crrev.com/23644ddffd174e5cb930031259f6fdbb80e66faa
Cr-Commit-Position: refs/heads/master@{#40031}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 22 (13 generated)
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
[parser] Load outer ScopeInfo from SharedFunctionInfo.
This switches the {ParseInfo} constructor to always determine the outer
scope info from the shared function info instead of a concrete closure.
It is a precursor to deprecate the construtor taking a closure entirely
and hence make the fact that we can parse without a closure explicit.
R=
BUG=v8:2206
==========
to
==========
[parser] Load outer ScopeInfo from SharedFunctionInfo.
This switches the {ParseInfo} constructor to always determine the outer
scope info from the shared function info instead of a concrete closure.
It is a precursor to deprecate the constructor taking closures entirely
and hence make the fact that we can parse without a closure explicit.
R=
BUG=v8:2206
==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from
==========
[parser] Load outer ScopeInfo from SharedFunctionInfo.
This switches the {ParseInfo} constructor to always determine the outer
scope info from the shared function info instead of a concrete closure.
It is a precursor to deprecate the constructor taking closures entirely
and hence make the fact that we can parse without a closure explicit.
R=
BUG=v8:2206
==========
to
==========
[parser] Load outer ScopeInfo from SharedFunctionInfo.
This switches the {ParseInfo} constructor to always determine the outer
scope info from the shared function info instead of a concrete closure.
It is a precursor to deprecate the constructor taking closures entirely
and hence make the fact that we can parse without a closure explicit.
R=jochen@chromium.org
BUG=v8:2206
==========
mstarzinger@chromium.org changed reviewers: + jochen@chromium.org
lgtm
The CQ bit was checked by mstarzinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mstarzinger@chromium.org changed reviewers: + marja@chromium.org
Marja: PTAL, need parser owner review.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25788)
owner rubberstamp lgtm
The CQ bit was checked by mstarzinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
[parser] Load outer ScopeInfo from SharedFunctionInfo.
This switches the {ParseInfo} constructor to always determine the outer
scope info from the shared function info instead of a concrete closure.
It is a precursor to deprecate the constructor taking closures entirely
and hence make the fact that we can parse without a closure explicit.
R=jochen@chromium.org
BUG=v8:2206
==========
to
==========
[parser] Load outer ScopeInfo from SharedFunctionInfo.
This switches the {ParseInfo} constructor to always determine the outer
scope info from the shared function info instead of a concrete closure.
It is a precursor to deprecate the constructor taking closures entirely
and hence make the fact that we can parse without a closure explicit.
R=jochen@chromium.org
BUG=v8:2206
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
[parser] Load outer ScopeInfo from SharedFunctionInfo.
This switches the {ParseInfo} constructor to always determine the outer
scope info from the shared function info instead of a concrete closure.
It is a precursor to deprecate the constructor taking closures entirely
and hence make the fact that we can parse without a closure explicit.
R=jochen@chromium.org
BUG=v8:2206
==========
to
==========
[parser] Load outer ScopeInfo from SharedFunctionInfo.
This switches the {ParseInfo} constructor to always determine the outer
scope info from the shared function info instead of a concrete closure.
It is a precursor to deprecate the constructor taking closures entirely
and hence make the fact that we can parse without a closure explicit.
R=jochen@chromium.org
BUG=v8:2206
Committed: https://crrev.com/23644ddffd174e5cb930031259f6fdbb80e66faa
Cr-Commit-Position: refs/heads/master@{#40031}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/23644ddffd174e5cb930031259f6fdbb80e66faa Cr-Commit-Position: refs/heads/master@{#40031} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
