Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2397043002: Allow variations controls for the time banners are suppressed after ignore/dismiss. (Closed)

Created:
4 years, 2 months ago by dominickn
Modified:
4 years, 2 months ago
Reviewers:
gone
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow variations controls for the time banners are suppressed after ignore/dismiss. This CL implements variations querying and control for the number of days after an app banner is dismissed or ignored that the banner will not be shown for that site. BUG=653339 Committed: https://crrev.com/9c6743858ca3e02015f13239045f4d80c47e33aa Cr-Commit-Position: refs/heads/master@{#423667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -8 lines) Patch
M chrome/browser/banners/app_banner_settings_helper.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/banners/app_banner_settings_helper.cc View 8 chunks +40 lines, -8 lines 0 comments Download
M chrome/browser/banners/app_banner_settings_helper_unittest.cc View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dominickn
PTAL, thanks (benwells is away)! Hoping to get this into M55. :)
4 years, 2 months ago (2016-10-06 00:31:40 UTC) #3
gone
lgtm
4 years, 2 months ago (2016-10-06 17:21:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397043002/1
4 years, 2 months ago (2016-10-06 20:38:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 20:52:09 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 20:53:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c6743858ca3e02015f13239045f4d80c47e33aa
Cr-Commit-Position: refs/heads/master@{#423667}

Powered by Google App Engine
This is Rietveld 408576698