Allow variations controls for the time banners are suppressed after ignore/dismiss.

chrome/browser/banners/app_banner_settings_helper_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "chrome/browser/banners/app_banner_metrics.h"
 #include "chrome/browser/banners/app_banner_settings_helper.h"
 #include "chrome/browser/engagement/site_engagement_service.h"
@@ skipping 631 matching lines @@
             AppBannerSettingsHelper::ShouldShowBanner(
                 web_contents(), url, kTestPackageName, reference_time));
 
   // Block the site more recently. Now it should not be shown.
   AppBannerSettingsHelper::RecordBannerEvent(
       web_contents(), url, kTestPackageName,
       AppBannerSettingsHelper::APP_BANNER_EVENT_DID_BLOCK, two_months_ago);
   EXPECT_EQ(PREVIOUSLY_BLOCKED,
             AppBannerSettingsHelper::ShouldShowBanner(
                 web_contents(), url, kTestPackageName, reference_time));
+
+  // Change the number of days enforced.
+  AppBannerSettingsHelper::SetDaysAfterDismissAndIgnoreToTrigger(59, 14);
+
+  EXPECT_EQ(NO_ERROR_DETECTED,
+            AppBannerSettingsHelper::ShouldShowBanner(
+                web_contents(), url, kTestPackageName, reference_time));
 }
 
 TEST_F(AppBannerSettingsHelperTest, ShouldNotShowAfterShowing) {
   GURL url(kTestURL);
   NavigateAndCommit(url);
 
   base::Time reference_time = GetReferenceTime();
   base::Time one_day_ago = reference_time - base::TimeDelta::FromDays(1);
   base::Time one_week_ago = reference_time - base::TimeDelta::FromDays(7);
   base::Time one_year_ago = reference_time - base::TimeDelta::FromDays(366);
@@ skipping 22 matching lines @@
             AppBannerSettingsHelper::ShouldShowBanner(
                 web_contents(), url, kTestPackageName, reference_time));
 
   // Show the site more recently. Now it should not be shown.
   AppBannerSettingsHelper::RecordBannerEvent(
       web_contents(), url, kTestPackageName,
       AppBannerSettingsHelper::APP_BANNER_EVENT_DID_SHOW, one_week_ago);
   EXPECT_EQ(PREVIOUSLY_IGNORED,
             AppBannerSettingsHelper::ShouldShowBanner(
                 web_contents(), url, kTestPackageName, reference_time));
+
+  // Change the number of days enforced.
+  AppBannerSettingsHelper::SetDaysAfterDismissAndIgnoreToTrigger(90, 6);
+
+  EXPECT_EQ(NO_ERROR_DETECTED,
+            AppBannerSettingsHelper::ShouldShowBanner(
+                web_contents(), url, kTestPackageName, reference_time));
 }
 
 TEST_F(AppBannerSettingsHelperTest, ShouldNotShowAfterAdding) {
   GURL url(kTestURL);
   NavigateAndCommit(url);
 
   base::Time reference_time = GetReferenceTime();
   base::Time one_day_ago = reference_time - base::TimeDelta::FromDays(1);
   base::Time one_year_ago = reference_time - base::TimeDelta::FromDays(366);
 
@@ skipping 167 matching lines @@
       first_day);
   EXPECT_TRUE(
       AppBannerSettingsHelper::WasLaunchedRecently(profile(), url, first_day));
   EXPECT_TRUE(
       AppBannerSettingsHelper::WasLaunchedRecently(profile(), url, ninth_day));
   EXPECT_TRUE(
       AppBannerSettingsHelper::WasLaunchedRecently(profile(), url, tenth_day));
   EXPECT_TRUE(AppBannerSettingsHelper::WasLaunchedRecently(profile(), url,
                                                            eleventh_day));
 }