Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 239703006: Retract SkPicture::kOptimizeForClippedPlayback_RecordingFlag from public API (Closed)

Created:
6 years, 8 months ago by robertphillips
Modified:
6 years, 8 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Retract SkPicture::kOptimizeForClippedPlayback_RecordingFlag from public API This CL sets the stage for retracting the SkPicture::kOptimizeForClippedPlayback_RecordingFlag flag from the public API (more work needs to be done in Blink & Chrome). In the new world the only way to set this flag (and thus instantiate an SkPicture-derived class) is by passing a factory to the SkPictureRecorder class. This is to get all clients always using factories so that we can then change the factory call used (i.e., so the factory just creates a BBH) and do away with the SkPicture-derived classes. BUG=skia:2315 Committed: http://code.google.com/p/skia/source/detail?r=14221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -66 lines) Patch
M dm/DMReplayTask.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M gm/gmmain.cpp View 6 chunks +27 lines, -7 lines 0 comments Download
M gyp/core.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkPicture.h View 5 chunks +18 lines, -1 line 0 comments Download
A include/core/SkRTreePicture.h View 1 chunk +36 lines, -0 lines 0 comments Download
M include/core/SkTileGridPicture.h View 1 chunk +2 lines, -4 lines 0 comments Download
M samplecode/SamplePictFile.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkQuadTreePicture.h View 2 chunks +5 lines, -4 lines 0 comments Download
A src/core/SkRTreePicture.cpp View 1 chunk +25 lines, -0 lines 0 comments Download
M tests/ImageFilterTest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/PictureTest.cpp View 4 chunks +6 lines, -4 lines 0 comments Download
M tests/TileGridTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/PictureRenderer.cpp View 3 chunks +4 lines, -27 lines 0 comments Download
M tools/bench_record.cpp View 4 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
6 years, 8 months ago (2014-04-16 14:50:09 UTC) #1
reed1
lgtm
6 years, 8 months ago (2014-04-16 14:52:11 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 8 months ago (2014-04-16 15:15:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/239703006/1
6 years, 8 months ago (2014-04-16 15:16:05 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 16:02:28 UTC) #5
Message was sent while issue was closed.
Change committed as 14221

Powered by Google App Engine
This is Rietveld 408576698