Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 23970004: Revert r16648, r16641, r16638 and r16637. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger
Modified:
7 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Revert r16648, r16641, r16638 and r16637. Original descriptions were: - "Refactor and cleanup VirtualMemory." - "Fix typo." - "Deuglify V8_INLINE and V8_NOINLINE." - "Don't align size on allocation granularity for unaligned ReserveRegion calls." Reasons for the revert are: - Our mjsunit test suite slower by a factor of 5(!) in release mode. - Flaky cctest/test-alloc/CodeRange on all architectures and platforms. - Tankage of Sunspider by about 6% overall (unverified). TBR=bmeurer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2077 lines, -1489 lines) Patch
include/v8.h View 90 chunks +236 lines, -231 lines 0 comments Download
include/v8config.h View 5 chunks +6 lines, -35 lines 0 comments Download
src/arm/codegen-arm.cc View 6 chunks +6 lines, -15 lines 0 comments Download
src/cpu.cc View 1 chunk +1 line, -1 line 0 comments Download
src/deoptimizer.cc View 2 chunks +9 lines, -3 lines 0 comments Download
src/globals.h View 1 chunk +3 lines, -3 lines 0 comments Download
src/heap.cc View 11 chunks +14 lines, -15 lines 0 comments Download
src/heap-inl.h View 3 chunks +3 lines, -4 lines 0 comments Download
src/ia32/codegen-ia32.cc View 8 chunks +12 lines, -20 lines 0 comments Download
src/incremental-marking.cc View 1 chunk +1 line, -1 line 0 comments Download
src/mips/codegen-mips.cc View 2 chunks +2 lines, -5 lines 0 comments Download
src/platform.h View 3 chunks +121 lines, -0 lines 0 comments Download
src/platform-cygwin.cc View 3 chunks +138 lines, -2 lines 0 comments Download
src/platform-freebsd.cc View 2 chunks +153 lines, -0 lines 0 comments Download
src/platform-linux.cc View 6 chunks +165 lines, -17 lines 0 comments Download
src/platform-macos.cc View 5 chunks +164 lines, -3 lines 0 comments Download
src/platform-openbsd.cc View 2 chunks +154 lines, -0 lines 0 comments Download
src/platform-posix.cc View 2 chunks +102 lines, -0 lines 0 comments Download
src/platform-solaris.cc View 2 chunks +153 lines, -0 lines 0 comments Download
src/platform-win32.cc View 4 chunks +236 lines, -0 lines 0 comments Download
src/platform/elapsed-timer.h View 1 chunk +1 line, -1 line 0 comments Download
src/platform/mutex.h View 1 chunk +2 lines, -2 lines 0 comments Download
src/platform/mutex.cc View 4 chunks +12 lines, -12 lines 0 comments Download
src/platform/socket.h View 1 chunk +1 line, -1 line 0 comments Download
src/platform/virtual-memory.h View 1 chunk +0 lines, -211 lines 0 comments Download
src/platform/virtual-memory.cc View 1 chunk +0 lines, -513 lines 0 comments Download
src/spaces.h View 16 chunks +27 lines, -41 lines 0 comments Download
src/spaces.cc View 32 chunks +72 lines, -86 lines 0 comments Download
src/spaces-inl.h View 1 chunk +33 lines, -1 line 0 comments Download
src/store-buffer.cc View 4 chunks +4 lines, -5 lines 0 comments Download
src/utils/random-number-generator.h View 2 chunks +2 lines, -2 lines 0 comments Download
src/v8globals.h View 1 chunk +2 lines, -0 lines 0 comments Download
src/x64/codegen-x64.cc View 7 chunks +11 lines, -18 lines 0 comments Download
test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
test/cctest/test-api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
test/cctest/test-assembler-x64.cc View 8 chunks +49 lines, -29 lines 0 comments Download
test/cctest/test-code-stubs-arm.cc View 1 chunk +3 lines, -4 lines 0 comments Download
test/cctest/test-code-stubs-ia32.cc View 1 chunk +3 lines, -4 lines 0 comments Download
test/cctest/test-code-stubs-x64.cc View 1 chunk +3 lines, -4 lines 0 comments Download
test/cctest/test-macro-assembler-x64.cc View 23 chunks +125 lines, -89 lines 0 comments Download
test/cctest/test-platform-linux.cc View 1 chunk +14 lines, -0 lines 0 comments Download
test/cctest/test-platform-win32.cc View 1 chunk +14 lines, -0 lines 0 comments Download
test/cctest/test-spaces.cc View 11 chunks +18 lines, -20 lines 0 comments Download
test/cctest/test-virtual-memory.cc View 1 chunk +0 lines, -86 lines 0 comments Download
tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
7 years, 3 months ago (2013-09-11 18:29:32 UTC) #1
Michael Starzinger
7 years, 3 months ago (2013-09-11 18:30:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r16662 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698