📰 Spacing and fixes for the sign in promo

[NTP Client] Spacing and fixes for the sign in promo

- Fixes an exception when only the sign in promo is present on the NTP
and we attempt to make it peek

- Adds 20dp space between the promo and the status card if present

- Fixes to the bottom space calculation related to the dismissal of
sibling elements.

Preview: https://goo.gl/photos/94hhXK5rygGamFqt7

BUG=649670, 652578
Committed: https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8
Cr-Commit-Position: refs/heads/master@{#423525}

[dgn, 2016-10-05 19:41:54]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 19:42:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgn, 2016-10-05 19:42:34]

Description was changed from

==========
[NTP Client] Spacing and fixes for the sign in promo

- Fixes an exception when only the sign in promo is present on the NTP
and we attempt to make it peek

- Adds 20dp space between the promo and the status card if present

- Fixes to the bottom space calculation related to the dismissal of
sibling elements.

BUG=649670
==========

to

==========
[NTP Client] Spacing and fixes for the sign in promo

- Fixes an exception when only the sign in promo is present on the NTP
and we attempt to make it peek

- Adds 20dp space between the promo and the status card if present

- Fixes to the bottom space calculation related to the dismissal of
sibling elements.

Preview: https://goo.gl/photos/94hhXK5rygGamFqt7

BUG=649670
==========

[dgn, 2016-10-05 19:42:48]

dgn@chromium.org changed reviewers:
+ bauerb@chromium.org

[dgn, 2016-10-05 19:42:48]

PTAL

[dgn, 2016-10-05 19:44:12]

Description was changed from

==========
[NTP Client] Spacing and fixes for the sign in promo

- Fixes an exception when only the sign in promo is present on the NTP
and we attempt to make it peek

- Adds 20dp space between the promo and the status card if present

- Fixes to the bottom space calculation related to the dismissal of
sibling elements.

Preview: https://goo.gl/photos/94hhXK5rygGamFqt7

BUG=649670
==========

to

==========
[NTP Client] Spacing and fixes for the sign in promo

- Fixes an exception when only the sign in promo is present on the NTP
and we attempt to make it peek

- Adds 20dp space between the promo and the status card if present

- Fixes to the bottom space calculation related to the dismissal of
sibling elements.

Preview: https://goo.gl/photos/94hhXK5rygGamFqt7

BUG=649670,652578
==========

[commit-bot: I haz the power, 2016-10-05 19:54:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 19:54:50]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Bernhard Bauer, 2016-10-06 10:48:11]

lgtm

https://codereview.chromium.org/2396863003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
(right):

https://codereview.chromium.org/2396863003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java:237:
protected static boolean isCard(@NewTabPageItem.ViewType int type) {
Package private maybe?

[dgn, 2016-10-06 10:49:50]

Thanks!

https://codereview.chromium.org/2396863003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
(right):

https://codereview.chromium.org/2396863003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java:237:
protected static boolean isCard(@NewTabPageItem.ViewType int type) {
On 2016/10/06 10:48:11, Bernhard Bauer wrote:
> Package private maybe?

it's used in a subclass so I wanted to let it be accessible there even if the
class moves. I could make it public otherwise.

[Bernhard Bauer, 2016-10-06 10:54:36]

https://codereview.chromium.org/2396863003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
(right):

https://codereview.chromium.org/2396863003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java:237:
protected static boolean isCard(@NewTabPageItem.ViewType int type) {
On 2016/10/06 10:49:50, dgn wrote:
> On 2016/10/06 10:48:11, Bernhard Bauer wrote:
> > Package private maybe?
> 
> it's used in a subclass so I wanted to let it be accessible there even if the
> class moves. I could make it public otherwise.

Where? I've only seen it used outside of this class in NewTabPageAdapter.

[dgn, 2016-10-06 12:22:29]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[dgn, 2016-10-06 12:22:42]

https://codereview.chromium.org/2396863003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
(right):

https://codereview.chromium.org/2396863003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java:237:
protected static boolean isCard(@NewTabPageItem.ViewType int type) {
On 2016/10/06 10:54:36, Bernhard Bauer wrote:
> On 2016/10/06 10:49:50, dgn wrote:
> > On 2016/10/06 10:48:11, Bernhard Bauer wrote:
> > > Package private maybe?
> > 
> > it's used in a subclass so I wanted to let it be accessible there even if
the
> > class moves. I could make it public otherwise.
> 
> Where? I've only seen it used outside of this class in NewTabPageAdapter.

Oh right, I was thinking about SignInPromo.ViewHolder, that used it at some
point but I removed that. Making it public then.

[commit-bot: I haz the power, 2016-10-06 12:22:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 12:52:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 12:52:22]

Dry run: This issue passed the CQ dry run.

[dgn, 2016-10-06 14:29:06]

The CQ bit was checked by dgn@chromium.org

[dgn, 2016-10-06 14:29:06]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2396863003/#ps20001
(title: "rebase, address comments")

[commit-bot: I haz the power, 2016-10-06 14:29:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 14:34:44]

Description was changed from

==========
[NTP Client] Spacing and fixes for the sign in promo

- Fixes an exception when only the sign in promo is present on the NTP
and we attempt to make it peek

- Adds 20dp space between the promo and the status card if present

- Fixes to the bottom space calculation related to the dismissal of
sibling elements.

Preview: https://goo.gl/photos/94hhXK5rygGamFqt7

BUG=649670,652578
==========

to

==========
[NTP Client] Spacing and fixes for the sign in promo

- Fixes an exception when only the sign in promo is present on the NTP
and we attempt to make it peek

- Adds 20dp space between the promo and the status card if present

- Fixes to the bottom space calculation related to the dismissal of
sibling elements.

Preview: https://goo.gl/photos/94hhXK5rygGamFqt7

BUG=649670,652578
==========

[commit-bot: I haz the power, 2016-10-06 14:34:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 14:38:13]

Description was changed from

==========
[NTP Client] Spacing and fixes for the sign in promo

- Fixes an exception when only the sign in promo is present on the NTP
and we attempt to make it peek

- Adds 20dp space between the promo and the status card if present

- Fixes to the bottom space calculation related to the dismissal of
sibling elements.

Preview: https://goo.gl/photos/94hhXK5rygGamFqt7

BUG=649670,652578
==========

to

==========
[NTP Client] Spacing and fixes for the sign in promo

- Fixes an exception when only the sign in promo is present on the NTP
and we attempt to make it peek

- Adds 20dp space between the promo and the status card if present

- Fixes to the bottom space calculation related to the dismissal of
sibling elements.

Preview: https://goo.gl/photos/94hhXK5rygGamFqt7

BUG=649670,652578

Committed: https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8
Cr-Commit-Position: refs/heads/master@{#423525}
==========

[commit-bot: I haz the power, 2016-10-06 14:38:14]

Patchset 2 (id:??) landed as
https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8
Cr-Commit-Position: refs/heads/master@{#423525}

[nasko, 2016-10-06 20:10:30]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2399983002/ by nasko@chromium.org.

The reason for reverting is: Reverting due to test failures in
chrome_public_test_apk

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg...

failures:
org.chromium.chrome.browser.widget.OverviewListLayoutTest#testCloseAllIncognito
org.chromium.chrome.browser.widget.OverviewListLayoutTest#testModelSwitcherVisibility.