📰 Use the separate button style for the NoArticles status

[NTP Client] Use the separate button style for the NoArticles status

Makes the articles and bookmarks sections use the same style of status
card when they have no snippets.

the hasMoreButton property of categories now only determines whether
the action item will be shown when there are suggestions to display.

This patch also lets the SuggestionsCategoryInfo be aware of the
current category it is describing, and moves various category specific
behaviours into the SuggestionsCategoryInfo class.

Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7

BUG=649670
Committed: https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171
Cr-Commit-Position: refs/heads/master@{#423517}

[dgn, 2016-10-04 15:26:25]

Description was changed from

==========
[NTP Client] Use the separate button style for the NoArticles status

Makes the articles and bookmarks sections use the same style of status
card when they have no snippets.

Also adds some space between the sign in promo and the status card
when both are displayed.

BUG=649670
==========

to

==========
[NTP Client] Use the separate button style for the NoArticles status

Makes the articles and bookmarks sections use the same style of status
card when they have no snippets.

Also adds some space between the sign in promo and the status card
when both are displayed.

BUG=649670
==========

[dgn, 2016-10-04 15:31:19]

Description was changed from

==========
[NTP Client] Use the separate button style for the NoArticles status

Makes the articles and bookmarks sections use the same style of status
card when they have no snippets.

Also adds some space between the sign in promo and the status card
when both are displayed.

BUG=649670
==========

to

==========
[NTP Client] Use the separate button style for the NoArticles status

Makes the articles and bookmarks sections use the same style of status
card when they have no snippets.

Also adds some space between the sign in promo and the status card
when both are displayed.

Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7

BUG=649670
==========

[dgn, 2016-10-04 15:31:28]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[dgn, 2016-10-04 15:31:39]

dgn@chromium.org changed reviewers:
+ bauerb@chromium.org

[dgn, 2016-10-04 15:31:40]

PTAL

[commit-bot: I haz the power, 2016-10-04 15:32:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgn, 2016-10-04 15:39:54]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 15:40:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgn, 2016-10-04 15:40:18]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[Bernhard Bauer, 2016-10-04 15:40:28]

https://codereview.chromium.org/2392943002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java
(right):

https://codereview.chromium.org/2392943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java:109:
private int mSeparationSpaceSize;
This can be final.

https://codereview.chromium.org/2392943002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java
(right):

https://codereview.chromium.org/2392943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java:73:
public static void performEmptyStateAction(
Would it make sense to make this a non-static method and add the actual category
into to the class?

https://codereview.chromium.org/2392943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java:89:
Log.wtf(TAG, "More action called on a dynamically added section: %d", category);
Small nit: Put "more" in quotes so it doesn't read like a qualified for
"action"?

https://codereview.chromium.org/2392943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java:98:
public static int getNoSuggestionDescriptionForCategory(@CategoryInt int
category) {
Annotate with @StringRes?

[commit-bot: I haz the power, 2016-10-04 15:40:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 16:00:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 16:00:39]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dgn, 2016-10-05 14:36:52]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 14:37:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgn, 2016-10-05 14:38:30]

Description was changed from

==========
[NTP Client] Use the separate button style for the NoArticles status

Makes the articles and bookmarks sections use the same style of status
card when they have no snippets.

Also adds some space between the sign in promo and the status card
when both are displayed.

Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7

BUG=649670
==========

to

==========
[NTP Client] Use the separate button style for the NoArticles status

Makes the articles and bookmarks sections use the same style of status
card when they have no snippets.

Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7

BUG=649670
==========

[commit-bot: I haz the power, 2016-10-05 14:47:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 14:47:28]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dgn, 2016-10-05 14:51:11]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 14:51:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgn, 2016-10-05 14:54:34]

Description was changed from

==========
[NTP Client] Use the separate button style for the NoArticles status

Makes the articles and bookmarks sections use the same style of status
card when they have no snippets.

Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7

BUG=649670
==========

to

==========
[NTP Client] Use the separate button style for the NoArticles status

Makes the articles and bookmarks sections use the same style of status
card when they have no snippets.

the hasMoreButton property of categories now only determines whether
the action item will be shown when there are suggestions to display.

This patch also lets the SuggestionsCategoryInfo be aware of the
current category it is describing, and moves various category specific
behaviours into the SuggestionsCategoryInfo class.

Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7

BUG=649670
==========

[dgn, 2016-10-05 14:55:24]

PTAL. I removed the signin promo related thing out of this CL, as I ran into a
bunch of edge cases. I will do all the rest in another CL.

https://codereview.chromium.org/2392943002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java
(right):

https://codereview.chromium.org/2392943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java:109:
private int mSeparationSpaceSize;
On 2016/10/04 15:40:28, Bernhard Bauer wrote:
> This can be final.

Done.

https://codereview.chromium.org/2392943002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java
(right):

https://codereview.chromium.org/2392943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java:73:
public static void performEmptyStateAction(
On 2016/10/04 15:40:28, Bernhard Bauer wrote:
> Would it make sense to make this a non-static method and add the actual
category
> into to the class?

Done.

https://codereview.chromium.org/2392943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java:89:
Log.wtf(TAG, "More action called on a dynamically added section: %d", category);
On 2016/10/04 15:40:28, Bernhard Bauer wrote:
> Small nit: Put "more" in quotes so it doesn't read like a qualified for
> "action"?

Done.

https://codereview.chromium.org/2392943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java:98:
public static int getNoSuggestionDescriptionForCategory(@CategoryInt int
category) {
On 2016/10/04 15:40:28, Bernhard Bauer wrote:
> Annotate with @StringRes?

Done.

https://codereview.chromium.org/2392943002/diff/60001/chrome/android/junit/sr...
File
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
(left):

https://codereview.chromium.org/2392943002/diff/60001/chrome/android/junit/sr...
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java:249:
assertEquals(NewTabPageItem.VIEW_TYPE_ABOVE_THE_FOLD,
mAdapter.getItemViewType(0));
Removed since it seems to do the exact same thing as assertItemsFor(), now that
it has been rewritten to check types instead of just the number of elements.

[commit-bot: I haz the power, 2016-10-05 15:03:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 15:03:04]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dgn, 2016-10-06 11:25:53]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 11:26:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 11:57:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 11:57:11]

Dry run: This issue passed the CQ dry run.

[dgn, 2016-10-06 12:24:34]

👈 Ping :)

[Bernhard Bauer, 2016-10-06 12:29:10]

Sorry, forgot to publish drafts.

👍 LGTM with nits:

https://codereview.chromium.org/2392943002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java
(right):

https://codereview.chromium.org/2392943002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java:65:
public int getCategory() {
@CategoryInt

https://codereview.chromium.org/2392943002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
(right):

https://codereview.chromium.org/2392943002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java:118:
public int getCategory() {
@CategoryInt :)

[dgn, 2016-10-06 13:05:14]

The CQ bit was checked by dgn@chromium.org

[dgn, 2016-10-06 13:05:14]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2392943002/#ps100001
(title: "address nit")

[commit-bot: I haz the power, 2016-10-06 13:05:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgn, 2016-10-06 13:05:49]

Thanks!

https://codereview.chromium.org/2392943002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java
(right):

https://codereview.chromium.org/2392943002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java:65:
public int getCategory() {
On 2016/10/06 12:29:10, Bernhard Bauer wrote:
> @CategoryInt

Done.

https://codereview.chromium.org/2392943002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
(right):

https://codereview.chromium.org/2392943002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java:118:
public int getCategory() {
On 2016/10/06 12:29:10, Bernhard Bauer wrote:
> @CategoryInt :)

Done.

[commit-bot: I haz the power, 2016-10-06 14:13:41]

Description was changed from

==========
[NTP Client] Use the separate button style for the NoArticles status

Makes the articles and bookmarks sections use the same style of status
card when they have no snippets.

the hasMoreButton property of categories now only determines whether
the action item will be shown when there are suggestions to display.

This patch also lets the SuggestionsCategoryInfo be aware of the
current category it is describing, and moves various category specific
behaviours into the SuggestionsCategoryInfo class.

Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7

BUG=649670
==========

to

==========
[NTP Client] Use the separate button style for the NoArticles status

Makes the articles and bookmarks sections use the same style of status
card when they have no snippets.

the hasMoreButton property of categories now only determines whether
the action item will be shown when there are suggestions to display.

This patch also lets the SuggestionsCategoryInfo be aware of the
current category it is describing, and moves various category specific
behaviours into the SuggestionsCategoryInfo class.

Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7

BUG=649670
==========

[commit-bot: I haz the power, 2016-10-06 14:13:42]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-06 14:15:45]

Description was changed from

==========
[NTP Client] Use the separate button style for the NoArticles status

Makes the articles and bookmarks sections use the same style of status
card when they have no snippets.

the hasMoreButton property of categories now only determines whether
the action item will be shown when there are suggestions to display.

This patch also lets the SuggestionsCategoryInfo be aware of the
current category it is describing, and moves various category specific
behaviours into the SuggestionsCategoryInfo class.

Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7

BUG=649670
==========

to

==========
[NTP Client] Use the separate button style for the NoArticles status

Makes the articles and bookmarks sections use the same style of status
card when they have no snippets.

the hasMoreButton property of categories now only determines whether
the action item will be shown when there are suggestions to display.

This patch also lets the SuggestionsCategoryInfo be aware of the
current category it is describing, and moves various category specific
behaviours into the SuggestionsCategoryInfo class.

Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7

BUG=649670

Committed: https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171
Cr-Commit-Position: refs/heads/master@{#423517}
==========

[commit-bot: I haz the power, 2016-10-06 14:15:47]

Patchset 6 (id:??) landed as
https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171
Cr-Commit-Position: refs/heads/master@{#423517}

[Theresa, 2016-10-06 17:33:41]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2398463005/ by twellington@chromium.org.

The reason for reverting is: Breaking tests on Android bots, see bug comment..