Support margin-top for legend in fieldset.

Support margin-top for legend in fieldset.

The implementation aligns with Edge, Gecko centers the legend+margins, which
looks undesirable to me.  The specs say nothing about this.

The new behaviour causes two tests to change, both have been rebaselined. One
was additionally modified to not trigger the scrollbar, which in turn would
render differently on various platforms.

BUG=554077
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/462e2f8e1a0f0a09efa7c8bcc34da36fd7b532ca
Cr-Commit-Position: refs/heads/master@{#425127}

[Karl Øygard, 2016-10-05 13:58:15]

Description was changed from

==========
Support margin-top for legend in fieldset.

BUG=554077
==========

to

==========
Support margin-top for legend in fieldset.

BUG=554077
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Karl Øygard, 2016-10-06 16:44:24]

The CQ bit was checked by karlo@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 16:44:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 18:03:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 18:03:10]

Dry run: This issue passed the CQ dry run.

[Karl Øygard, 2016-10-07 11:40:19]

Description was changed from

==========
Support margin-top for legend in fieldset.

BUG=554077
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Support margin-top for legend in fieldset.

The implementation aligns with Edge, Gecko centers the legend+margins, which
looks undesirable to me.  The specs say nothing about this.

The new behaviour causes two tests to change, both have been rebaselined. One
was additionally modified to not trigger the scrollbar, which in turn would
render differently on various platforms.

BUG=554077
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Karl Øygard, 2016-10-07 12:05:22]

Description was changed from

==========
Support margin-top for legend in fieldset.

The implementation aligns with Edge, Gecko centers the legend+margins, which
looks undesirable to me.  The specs say nothing about this.

The new behaviour causes two tests to change, both have been rebaselined. One
was additionally modified to not trigger the scrollbar, which in turn would
render differently on various platforms.

BUG=554077
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Support margin-top for legend in fieldset.

The implementation aligns with Edge, Gecko centers the legend+margins, which
looks undesirable to me.  The specs say nothing about this.

The new behaviour causes two tests to change, both have been rebaselined. One
was additionally modified to not trigger the scrollbar, which in turn would
render differently on various platforms.

BUG=554077
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Karl Øygard, 2016-10-10 10:34:38]

The CQ bit was checked by karlo@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 10:34:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 10:37:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 10:37:39]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Karl Øygard, 2016-10-11 11:18:56]

The CQ bit was checked by karlo@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 11:19:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 13:59:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 13:59:19]

Dry run: This issue passed the CQ dry run.

[Karl Øygard, 2016-10-12 20:43:47]

karlo@opera.com changed reviewers:
+ eae@chromium.org

[Karl Øygard, 2016-10-12 20:43:48]

ptal

[eae, 2016-10-12 20:52:03]

This is great, thank you!

[mstensho (USE GERRIT), 2016-10-13 08:26:33]

On 2016/10/12 20:52:03, eae wrote:
> This is great, thank you!

Can has ltgm? :)

[eae, 2016-10-13 17:30:10]

OOops, my bad
LGTM!

[eae, 2016-10-13 17:30:48]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-10-13 17:31:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 19:33:27]

Description was changed from

==========
Support margin-top for legend in fieldset.

The implementation aligns with Edge, Gecko centers the legend+margins, which
looks undesirable to me.  The specs say nothing about this.

The new behaviour causes two tests to change, both have been rebaselined. One
was additionally modified to not trigger the scrollbar, which in turn would
render differently on various platforms.

BUG=554077
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Support margin-top for legend in fieldset.

The implementation aligns with Edge, Gecko centers the legend+margins, which
looks undesirable to me.  The specs say nothing about this.

The new behaviour causes two tests to change, both have been rebaselined. One
was additionally modified to not trigger the scrollbar, which in turn would
render differently on various platforms.

BUG=554077
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-10-13 19:33:28]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-13 19:35:32]

Description was changed from

==========
Support margin-top for legend in fieldset.

The implementation aligns with Edge, Gecko centers the legend+margins, which
looks undesirable to me.  The specs say nothing about this.

The new behaviour causes two tests to change, both have been rebaselined. One
was additionally modified to not trigger the scrollbar, which in turn would
render differently on various platforms.

BUG=554077
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Support margin-top for legend in fieldset.

The implementation aligns with Edge, Gecko centers the legend+margins, which
looks undesirable to me.  The specs say nothing about this.

The new behaviour causes two tests to change, both have been rebaselined. One
was additionally modified to not trigger the scrollbar, which in turn would
render differently on various platforms.

BUG=554077
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/462e2f8e1a0f0a09efa7c8bcc34da36fd7b532ca
Cr-Commit-Position: refs/heads/master@{#425127}
==========

[commit-bot: I haz the power, 2016-10-13 19:35:33]

Patchset 5 (id:??) landed as
https://crrev.com/462e2f8e1a0f0a09efa7c8bcc34da36fd7b532ca
Cr-Commit-Position: refs/heads/master@{#425127}

[Gleb Lanbin, 2016-12-06 23:54:27]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2558683002/ by glebl@chromium.org.

The reason for reverting is: need to revert the previously landed patch
http://crrev.com/415577 that blocks the release.