Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Unified Diff: chrome/browser/translate/chrome_translate_client.cc

Issue 2396783002: Add LanguageModel, a keyed service that collects language info from CLD. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/chrome_translate_client.cc
diff --git a/chrome/browser/translate/chrome_translate_client.cc b/chrome/browser/translate/chrome_translate_client.cc
index bdda1de254536448ee35fd55d8be6d16749dd866..a038061bd16fa09a2acbd2ace511a1ce8e404cc4 100644
--- a/chrome/browser/translate/chrome_translate_client.cc
+++ b/chrome/browser/translate/chrome_translate_client.cc
@@ -14,6 +14,7 @@
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/infobars/infobar_service.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/translate/language_model_factory.h"
#include "chrome/browser/translate/translate_accept_languages_factory.h"
#include "chrome/browser/translate/translate_service.h"
#include "chrome/browser/ui/browser.h"
@@ -45,9 +46,13 @@ DEFINE_WEB_CONTENTS_USER_DATA_KEY(ChromeTranslateClient);
ChromeTranslateClient::ChromeTranslateClient(content::WebContents* web_contents)
: content::WebContentsObserver(web_contents),
translate_driver_(&web_contents->GetController()),
+ language_model_observer_(
+ LanguageModelFactory::GetInstance()->GetForBrowserContext(
+ web_contents->GetBrowserContext())),
translate_manager_(
new translate::TranslateManager(this, prefs::kAcceptLanguages)) {
translate_driver_.AddObserver(this);
+ translate_driver_.AddObserver(&language_model_observer_);
droger 2016/10/05 13:11:32 Need to call RemoveObserver at some point. Maybe
jkrcal 2016/10/05 15:14:46 Fixed by removing the observer completely (and usi
translate_driver_.set_translate_manager(translate_manager_.get());
}

Powered by Google App Engine
This is Rietveld 408576698