Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "chrome/browser/translate/chrome_translate_client.h" | 5 #include "chrome/browser/translate/chrome_translate_client.h" |
| 6 | 6 |
| 7 #include <vector> | 7 #include <vector> |
| 8 | 8 |
| 9 #include "base/logging.h" | 9 #include "base/logging.h" |
| 10 #include "base/path_service.h" | 10 #include "base/path_service.h" |
| 11 #include "base/strings/string_split.h" | 11 #include "base/strings/string_split.h" |
| 12 #include "build/build_config.h" | 12 #include "build/build_config.h" |
| 13 #include "chrome/browser/browser_process.h" | 13 #include "chrome/browser/browser_process.h" |
| 14 #include "chrome/browser/chrome_notification_types.h" | 14 #include "chrome/browser/chrome_notification_types.h" |
| 15 #include "chrome/browser/infobars/infobar_service.h" | 15 #include "chrome/browser/infobars/infobar_service.h" |
| 16 #include "chrome/browser/profiles/profile.h" | 16 #include "chrome/browser/profiles/profile.h" |
| 17 #include "chrome/browser/translate/language_model_factory.h" | |
| 17 #include "chrome/browser/translate/translate_accept_languages_factory.h" | 18 #include "chrome/browser/translate/translate_accept_languages_factory.h" |
| 18 #include "chrome/browser/translate/translate_service.h" | 19 #include "chrome/browser/translate/translate_service.h" |
| 19 #include "chrome/browser/ui/browser.h" | 20 #include "chrome/browser/ui/browser.h" |
| 20 #include "chrome/browser/ui/browser_finder.h" | 21 #include "chrome/browser/ui/browser_finder.h" |
| 21 #include "chrome/browser/ui/browser_tabstrip.h" | 22 #include "chrome/browser/ui/browser_tabstrip.h" |
| 22 #include "chrome/browser/ui/browser_window.h" | 23 #include "chrome/browser/ui/browser_window.h" |
| 23 #include "chrome/browser/ui/tabs/tab_strip_model.h" | 24 #include "chrome/browser/ui/tabs/tab_strip_model.h" |
| 24 #include "chrome/browser/ui/translate/translate_bubble_factory.h" | 25 #include "chrome/browser/ui/translate/translate_bubble_factory.h" |
| 25 #include "chrome/common/chrome_paths.h" | 26 #include "chrome/common/chrome_paths.h" |
| 26 #include "chrome/common/pref_names.h" | 27 #include "chrome/common/pref_names.h" |
| (...skipping 11 matching lines...) Expand all Loading... | |
| 38 #include "content/public/browser/notification_service.h" | 39 #include "content/public/browser/notification_service.h" |
| 39 #include "content/public/browser/render_view_host.h" | 40 #include "content/public/browser/render_view_host.h" |
| 40 #include "content/public/browser/web_contents.h" | 41 #include "content/public/browser/web_contents.h" |
| 41 #include "url/gurl.h" | 42 #include "url/gurl.h" |
| 42 | 43 |
| 43 DEFINE_WEB_CONTENTS_USER_DATA_KEY(ChromeTranslateClient); | 44 DEFINE_WEB_CONTENTS_USER_DATA_KEY(ChromeTranslateClient); |
| 44 | 45 |
| 45 ChromeTranslateClient::ChromeTranslateClient(content::WebContents* web_contents) | 46 ChromeTranslateClient::ChromeTranslateClient(content::WebContents* web_contents) |
| 46 : content::WebContentsObserver(web_contents), | 47 : content::WebContentsObserver(web_contents), |
| 47 translate_driver_(&web_contents->GetController()), | 48 translate_driver_(&web_contents->GetController()), |
| 49 language_model_observer_( | |
| 50 LanguageModelFactory::GetInstance()->GetForBrowserContext( | |
| 51 web_contents->GetBrowserContext())), | |
| 48 translate_manager_( | 52 translate_manager_( |
| 49 new translate::TranslateManager(this, prefs::kAcceptLanguages)) { | 53 new translate::TranslateManager(this, prefs::kAcceptLanguages)) { |
| 50 translate_driver_.AddObserver(this); | 54 translate_driver_.AddObserver(this); |
| 55 translate_driver_.AddObserver(&language_model_observer_); | |
|
droger
2016/10/05 13:11:32
Need to call RemoveObserver at some point.
Maybe
jkrcal
2016/10/05 15:14:46
Fixed by removing the observer completely (and usi
| |
| 51 translate_driver_.set_translate_manager(translate_manager_.get()); | 56 translate_driver_.set_translate_manager(translate_manager_.get()); |
| 52 } | 57 } |
| 53 | 58 |
| 54 ChromeTranslateClient::~ChromeTranslateClient() { | 59 ChromeTranslateClient::~ChromeTranslateClient() { |
| 55 translate_driver_.RemoveObserver(this); | 60 translate_driver_.RemoveObserver(this); |
| 56 } | 61 } |
| 57 | 62 |
| 58 translate::LanguageState& ChromeTranslateClient::GetLanguageState() { | 63 translate::LanguageState& ChromeTranslateClient::GetLanguageState() { |
| 59 return translate_manager_->GetLanguageState(); | 64 return translate_manager_->GetLanguageState(); |
| 60 } | 65 } |
| (...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 326 if (GetLanguageState().InTranslateNavigation()) | 331 if (GetLanguageState().InTranslateNavigation()) |
| 327 return; | 332 return; |
| 328 } | 333 } |
| 329 | 334 |
| 330 TranslateBubbleFactory::Show(browser->window(), web_contents(), step, | 335 TranslateBubbleFactory::Show(browser->window(), web_contents(), step, |
| 331 error_type); | 336 error_type); |
| 332 #else | 337 #else |
| 333 NOTREACHED(); | 338 NOTREACHED(); |
| 334 #endif | 339 #endif |
| 335 } | 340 } |
| OLD | NEW |