Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2396723003: fix pylint warning: build/toolchain/mac/linker_driver.py (Closed)

Created:
4 years, 2 months ago by Yoshisato Yanagisawa
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fix pylint warning: build/toolchain/mac/linker_driver.py W:134, 3: Unused variable 'head' (unused-variable) W:159, 3: Unused variable 'head' (unused-variable) Committed: https://crrev.com/f636eadf2f2096579005f581cc87963429cf4444 Cr-Commit-Position: refs/heads/master@{#423410}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use os.path.basename instead of os.path.split #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M build/toolchain/mac/linker_driver.py View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Yoshisato Yanagisawa
4 years, 2 months ago (2016-10-05 09:38:16 UTC) #2
Robert Sesek
lgtm
4 years, 2 months ago (2016-10-05 20:29:27 UTC) #4
Dirk Pranke
lgtm w/ nit. https://codereview.chromium.org/2396723003/diff/1/build/toolchain/mac/linker_driver.py File build/toolchain/mac/linker_driver.py (right): https://codereview.chromium.org/2396723003/diff/1/build/toolchain/mac/linker_driver.py#newcode133 build/toolchain/mac/linker_driver.py:133: out = os.path.split(linker_out)[1] Just use `os.path.basename(linker_out)` ...
4 years, 2 months ago (2016-10-06 01:28:15 UTC) #5
Yoshisato Yanagisawa
https://codereview.chromium.org/2396723003/diff/1/build/toolchain/mac/linker_driver.py File build/toolchain/mac/linker_driver.py (right): https://codereview.chromium.org/2396723003/diff/1/build/toolchain/mac/linker_driver.py#newcode133 build/toolchain/mac/linker_driver.py:133: out = os.path.split(linker_out)[1] On 2016/10/06 01:28:15, Dirk Pranke (slow) ...
4 years, 2 months ago (2016-10-06 01:37:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396723003/20001
4 years, 2 months ago (2016-10-06 01:38:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 02:53:31 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 02:56:26 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f636eadf2f2096579005f581cc87963429cf4444
Cr-Commit-Position: refs/heads/master@{#423410}

Powered by Google App Engine
This is Rietveld 408576698