Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3364)

Unified Diff: build/toolchain/mac/linker_driver.py

Issue 2396723003: fix pylint warning: build/toolchain/mac/linker_driver.py (Closed)
Patch Set: use os.path.basename instead of os.path.split Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/mac/linker_driver.py
diff --git a/build/toolchain/mac/linker_driver.py b/build/toolchain/mac/linker_driver.py
index 40676f6427dfb882840d2b9418ba21143633b5d5..a6024f5ae2a39463968b59f4ef38ba08064f9a7d 100755
--- a/build/toolchain/mac/linker_driver.py
+++ b/build/toolchain/mac/linker_driver.py
@@ -130,8 +130,8 @@ def RunDsymUtil(dsym_path_prefix, full_args):
raise ValueError('Unspecified dSYM output file')
linker_out = _FindLinkerOutput(full_args)
- (head, tail) = os.path.split(linker_out)
- dsym_out = os.path.join(dsym_path_prefix, tail + '.dSYM')
+ base = os.path.basename(linker_out)
+ dsym_out = os.path.join(dsym_path_prefix, base + '.dSYM')
# Remove old dSYMs before invoking dsymutil.
_RemovePath(dsym_out)
@@ -155,8 +155,8 @@ def RunSaveUnstripped(unstripped_path_prefix, full_args):
raise ValueError('Unspecified unstripped output file')
linker_out = _FindLinkerOutput(full_args)
- (head, tail) = os.path.split(linker_out)
- unstripped_out = os.path.join(unstripped_path_prefix, tail + '.unstripped')
+ base = os.path.basename(linker_out)
+ unstripped_out = os.path.join(unstripped_path_prefix, base + '.unstripped')
shutil.copyfile(linker_out, unstripped_out)
return [unstripped_out]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698