Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2396643002:
[Payments] Add Payment Request journey metrics. (Closed)
Description[Payments] Add Payment Request journey metrics.
BUG=653539
Committed: https://crrev.com/fed26f3f9b85d8b7234e29b6fa07ef66cde905b7
Cr-Commit-Position: refs/heads/master@{#424058}
Patch Set 1 #Patch Set 2 : Rebase #
Total comments: 12
Patch Set 3 : Addressed comments #
Total comments: 2
Patch Set 4 : Nit #Patch Set 5 : Nit #
Messages
Total messages: 41 (25 generated)
Patchset #1 (id:1) has been deleted
Patchset #2 (id:40001) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== [Payments] Add Payment Request journey metrics. BUG= ========== to ========== [Payments] Add Payment Request journey metrics. BUG=653539 ==========
The CQ bit was checked by sebsg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
Patchset #1 (id:60001) has been deleted
Hi Dan, could you please take a look? Thanks!
sebsg@chromium.org changed reviewers: + dfalcantara@chromium.org
Hi Dan, could you please take a look? Thanks!
sebsg@chromium.org changed reviewers: + jwd@chromium.org
Hi Jwd, could you please take a look at histograms.xml? Thanks!
The CQ bit was checked by sebsg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2396643002/diff/100001/tools/metrics/histogra... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2396643002/diff/100001/tools/metrics/histogra... tools/metrics/histograms/histograms.xml:41697: + The number of the user added an entry during a Payment Request. The first Not sure exactly what you meant by the first sentence, but maybe change it to something like "The number of user-added entries during ...". But I'm not sure if I'm getting the meaning right? https://codereview.chromium.org/2396643002/diff/100001/tools/metrics/histogra... tools/metrics/histograms/histograms.xml:41699: + specifies whether the user completed the checkout or aborted it. I'm not a BIG fan of talking about the suffixes in these summaries. Ideally, the added labels from the suffixes should make things clear. https://codereview.chromium.org/2396643002/diff/100001/tools/metrics/histogra... tools/metrics/histograms/histograms.xml:107506: +<histogram_suffixes name="PaymentRequestOutcome"> I'm not sure this is doing what you want? These two sets of suffixes will create PaymentRequest.NumberOfSelectionAdds.Completed and PaymentRequest.NumberOfSelectionAdds.ContactInfo, not PaymentRequest.NumberOfSelectionAdds.ContactInfo.Completed. You'd need to have the PaymentRequestSection apply to the PaymentsRequest.NumberOf* histograms, then the PaymentRequestOutcom appplies to the PaymentsRequest.NumberOf*.* histograms.
Seems fine on the Java end, but I don't understand the histograms changes. https://codereview.chromium.org/2396643002/diff/100001/chrome/android/java/sr... File chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java (right): https://codereview.chromium.org/2396643002/diff/100001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:311: mJourneyLogger.sectionIsRequested(PaymentRequestJourneyLogger.SECTION_SHIPPING_ADDRESS); It seems that these two calls always go together. Can you just fold the implementation for sectionIsRequested into setNumberOfSuggestionsShown? https://codereview.chromium.org/2396643002/diff/100001/chrome/android/java/sr... File chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java (right): https://codereview.chromium.org/2396643002/diff/100001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java:57: ++mSections[section].mNumberSelectionChanges; I'd post-increment just to make it clearer. https://codereview.chromium.org/2396643002/diff/100001/tools/metrics/histogra... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2396643002/diff/100001/tools/metrics/histogra... tools/metrics/histograms/histograms.xml:41697: + The number of the user added an entry during a Payment Request. The first number of times?
Patchset #3 (id:120001) has been deleted
Thanks for the quick review! Another look? https://codereview.chromium.org/2396643002/diff/100001/chrome/android/java/sr... File chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java (right): https://codereview.chromium.org/2396643002/diff/100001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:311: mJourneyLogger.sectionIsRequested(PaymentRequestJourneyLogger.SECTION_SHIPPING_ADDRESS); On 2016/10/07 18:54:28, dfalcantara wrote: > It seems that these two calls always go together. Can you just fold the > implementation for sectionIsRequested into setNumberOfSuggestionsShown? Done. https://codereview.chromium.org/2396643002/diff/100001/chrome/android/java/sr... File chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java (right): https://codereview.chromium.org/2396643002/diff/100001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java:57: ++mSections[section].mNumberSelectionChanges; On 2016/10/07 18:54:28, dfalcantara wrote: > I'd post-increment just to make it clearer. Done. https://codereview.chromium.org/2396643002/diff/100001/tools/metrics/histogra... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2396643002/diff/100001/tools/metrics/histogra... tools/metrics/histograms/histograms.xml:41697: + The number of the user added an entry during a Payment Request. The first On 2016/10/07 18:50:24, jwd wrote: > Not sure exactly what you meant by the first sentence, but maybe change it to > something like "The number of user-added entries during ...". But I'm not sure > if I'm getting the meaning right? Done. https://codereview.chromium.org/2396643002/diff/100001/tools/metrics/histogra... tools/metrics/histograms/histograms.xml:41697: + The number of the user added an entry during a Payment Request. The first On 2016/10/07 18:54:28, dfalcantara wrote: > number of times? Done. https://codereview.chromium.org/2396643002/diff/100001/tools/metrics/histogra... tools/metrics/histograms/histograms.xml:41699: + specifies whether the user completed the checkout or aborted it. On 2016/10/07 18:50:24, jwd wrote: > I'm not a BIG fan of talking about the suffixes in these summaries. Ideally, the > added labels from the suffixes should make things clear. Done. https://codereview.chromium.org/2396643002/diff/100001/tools/metrics/histogra... tools/metrics/histograms/histograms.xml:107506: +<histogram_suffixes name="PaymentRequestOutcome"> On 2016/10/07 18:50:24, jwd wrote: > I'm not sure this is doing what you want? These two sets of suffixes will create > PaymentRequest.NumberOfSelectionAdds.Completed and > PaymentRequest.NumberOfSelectionAdds.ContactInfo, not > PaymentRequest.NumberOfSelectionAdds.ContactInfo.Completed. You'd need to have > the PaymentRequestSection apply to the PaymentsRequest.NumberOf* histograms, > then the PaymentRequestOutcom appplies to the PaymentsRequest.NumberOf*.* > histograms. Done.
The CQ bit was checked by sebsg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
LGTM with small possibly optional nit. https://codereview.chromium.org/2396643002/diff/140001/tools/metrics/histogra... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2396643002/diff/140001/tools/metrics/histogra... tools/metrics/histograms/histograms.xml:107527: + label="The contact info section of a Payment Request"/> Nit: Maybe make it "For the..." for these labels?
Thanks! https://codereview.chromium.org/2396643002/diff/140001/tools/metrics/histogra... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2396643002/diff/140001/tools/metrics/histogra... tools/metrics/histograms/histograms.xml:107527: + label="The contact info section of a Payment Request"/> On 2016/10/07 20:37:13, jwd wrote: > Nit: Maybe make it "For the..." for these labels? Done.
The CQ bit was checked by sebsg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dfalcantara@chromium.org, jwd@chromium.org Link to the patchset: https://codereview.chromium.org/2396643002/#ps160001 (title: "Nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
The CQ bit was checked by sebsg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
The CQ bit was checked by sebsg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dfalcantara@chromium.org, jwd@chromium.org Link to the patchset: https://codereview.chromium.org/2396643002/#ps170001 (title: "Nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Payments] Add Payment Request journey metrics. BUG=653539 ========== to ========== [Payments] Add Payment Request journey metrics. BUG=653539 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:170001)
Message was sent while issue was closed.
Description was changed from ========== [Payments] Add Payment Request journey metrics. BUG=653539 ========== to ========== [Payments] Add Payment Request journey metrics. BUG=653539 Committed: https://crrev.com/fed26f3f9b85d8b7234e29b6fa07ef66cde905b7 Cr-Commit-Position: refs/heads/master@{#424058} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/fed26f3f9b85d8b7234e29b6fa07ef66cde905b7 Cr-Commit-Position: refs/heads/master@{#424058} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
