tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 51b2c69057a9778abc76969b5c093972495af944..598a1c97af9cc7cc18e940f027a218e90700a303 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -41691,6 +41691,43 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="PaymentRequest.NumberOfSelectionAdds">
+  <owner>sebsg@chromium.org</owner>
+  <summary>
+    The number of the user added an entry during a Payment Request. The first

[jwd, 2016/10/07 18:50:24]

Not sure exactly what you meant by the first sentence, but maybe change it to
something like "The number of user-added entries during ...". But I'm not sure
if I'm getting the meaning right?

[gone, 2016/10/07 18:54:28]

number of times?

[sebsg, 2016/10/07 19:40:32]

Done.

[sebsg, 2016/10/07 19:40:32]

Done.

+    suffix specifies the section associated with the entry. The second suffix
+    specifies whether the user completed the checkout or aborted it.

[jwd, 2016/10/07 18:50:24]

I'm not a BIG fan of talking about the suffixes in these summaries. Ideally, the
added labels from the suffixes should make things clear.

[sebsg, 2016/10/07 19:40:32]

Done.

+  </summary>
+</histogram>
+
+<histogram name="PaymentRequest.NumberOfSelectionChanges">
+  <owner>sebsg@chromium.org</owner>
+  <summary>
+    The number of the user changed an entry during a Payment Request. The first
+    suffix specifies the section associated with the entry. The second suffix
+    specifies whether the user completed the checkout or aborted it.
+  </summary>
+</histogram>
+
+<histogram name="PaymentRequest.NumberOfSelectionEdits">
+  <owner>sebsg@chromium.org</owner>
+  <summary>
+    The number of the user edited an entry during a Payment Request. The first
+    suffix specifies the section associated with the entry. The second suffix
+    specifies whether the user completed the checkout or aborted it.
+  </summary>
+</histogram>
+
+<histogram name="PaymentRequest.NumberOfSuggestionsShown">
+  <owner>sebsg@chromium.org</owner>
+  <summary>
+    The number of suggestions shown to the user during a payment request. The
+    first suffix specifies the section associated with the suggestions. The
+    second suffix specifies whether the user completed the checkout or aborted
+    it.
+  </summary>
+</histogram>
+
 <histogram name="PaymentRequest.RequestedInformation"
     enum="PaymentRequestRequestedInformation">
   <owner>sebsg@chromium.org</owner>
@@ -107466,6 +107503,31 @@ value.
   <affected-histogram name="PasswordManager.TotalAccountsHiRes.WithScheme"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="PaymentRequestOutcome">

[jwd, 2016/10/07 18:50:24]

I'm not sure this is doing what you want? These two sets of suffixes will create
PaymentRequest.NumberOfSelectionAdds.Completed and
PaymentRequest.NumberOfSelectionAdds.ContactInfo, not
PaymentRequest.NumberOfSelectionAdds.ContactInfo.Completed. You'd need to have
the PaymentRequestSection apply to the PaymentsRequest.NumberOf* histograms,
then the PaymentRequestOutcom appplies to the PaymentsRequest.NumberOf*.*
histograms.

[sebsg, 2016/10/07 19:40:32]

Done.

+  <suffix name="Completed" label="The Payment Request was completed"/>
+  <suffix name="UserAborted"
+      label="The Payment Request was aborted by the user"/>
+  <suffix name="OtherAborted"
+      label="The Payment Request was aborted but not but the user"/>
+  <affected-histogram name="PaymentRequest.NumberOfSelectionAdds"/>
+  <affected-histogram name="PaymentRequest.NumberOfSelectionChanges"/>
+  <affected-histogram name="PaymentRequest.NumberOfSelectionEdits"/>
+  <affected-histogram name="PaymentRequest.NumberOfSuggestionsShown"/>
+</histogram_suffixes>
+
+<histogram_suffixes name="PaymentRequestSection">
+  <suffix name="ContactInfo"
+      label="The contact info section of a Payment Request"/>
+  <suffix name="CreditCards"
+      label="The credit card section of a Payment Request"/>
+  <suffix name="ShippingAddress"
+      label="The shipping address section of a Payment Request"/>
+  <affected-histogram name="PaymentRequest.NumberOfSelectionAdds"/>
+  <affected-histogram name="PaymentRequest.NumberOfSelectionChanges"/>
+  <affected-histogram name="PaymentRequest.NumberOfSelectionEdits"/>
+  <affected-histogram name="PaymentRequest.NumberOfSuggestionsShown"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="PerformanceMonitor" separator=".">
   <suffix name="BrowserProcess"/>
   <suffix name="GPUProcess"/>