Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Issue 2396573002: reflow comments in modules/[presentation,storage] (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
haraken, dcheng
CC:
chromium-reviews, mlamouri+watch-screen-orientation_chromium.org, tzik, mlamouri+watch-blink_chromium.org, nhiroki, blink-reviews, kinuko+fileapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in modules/[presentation,storage] BUG=563793 TBR=haraken Committed: https://crrev.com/0632d8e8fd2d3b985563b3f9fd0291236d8f96b7 Cr-Commit-Position: refs/heads/master@{#422985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -30 lines) Patch
M third_party/WebKit/Source/modules/presentation/Presentation.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/Presentation.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnection.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnectionList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationError.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/quota/DeprecatedStorageInfo.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorPollingStrategy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/DOMWindowStorageController.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/StorageArea.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/StorageEvent.h View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
Nico
dcheng: review haraken: owner stamp
4 years, 2 months ago (2016-10-04 18:32:59 UTC) #4
dcheng
lgtm
4 years, 2 months ago (2016-10-04 21:38:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396573002/1
4 years, 2 months ago (2016-10-04 23:01:06 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 23:08:39 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0632d8e8fd2d3b985563b3f9fd0291236d8f96b7 Cr-Commit-Position: refs/heads/master@{#422985}
4 years, 2 months ago (2016-10-04 23:11:39 UTC) #18
haraken
4 years, 2 months ago (2016-10-05 01:15:51 UTC) #19
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698