third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp - Issue 2396573002: reflow comments in modules/[presentation,storage]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

Issue 2396573002: reflow comments in modules/[presentation,storage] (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/quota/DeprecatedStorageInfo.cpp ('k') | third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

diff --git a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

index 254970a103d39f9cdb172443ca67a38a4bbf04e7..e306ed482093344c32dd6505a81b301f7308f273 100644

--- a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

+++ b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

@@ -65,11 +65,12 @@ ScriptPromise RemotePlayback::getAvailability(ScriptState* scriptState) {

ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

- // TODO(avayvod): currently the availability is tracked for each media element

- // as soon as it's created, we probably want to limit that to when the page/element

- // is visible (see https://crbug.com/597281) and has default controls. If there's

- // no default controls, we should also start tracking availability on demand

- // meaning the Promise returned by getAvailability() will be resolved asynchronously.

+ // TODO(avayvod): Currently the availability is tracked for each media element

+ // as soon as it's created, we probably want to limit that to when the

+ // page/element is visible (see https://crbug.com/597281) and has default

+ // controls. If there are no default controls, we should also start tracking

+ // availability on demand meaning the Promise returned by getAvailability()

+ // will be resolved asynchronously.

RemotePlaybackAvailability* availability =

RemotePlaybackAvailability::take(resolver, m_availability);

m_availabilityObjects.append(availability);