Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java

Issue 2396523002: Unify NewTabPageItem and ItemGroup into a single tree-structured interface. (Closed)
Patch Set: review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java
index 9285ff97fbc3eef8551392785c31badf0959c34a..98b21db28eb16aeaa73556c5d62ce50a3df14f0b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java
@@ -13,7 +13,7 @@ import org.chromium.chrome.R;
* Card that is shown when the user needs to be made aware of some information about their
* configuration that affects the NTP suggestions.
*/
-public abstract class StatusItem implements NewTabPageItem, StatusCardViewHolder.DataSource {
+public abstract class StatusItem extends Leaf implements StatusCardViewHolder.DataSource {
public static StatusItem createNoSuggestionsItem(SuggestionsCategoryInfo categoryInfo) {
return new NoSuggestionsItem(categoryInfo);
}
@@ -50,12 +50,13 @@ public abstract class StatusItem implements NewTabPageItem, StatusCardViewHolder
}
@Override
- public int getType() {
- return NewTabPageItem.VIEW_TYPE_STATUS;
+ @ItemViewType
+ protected int getItemViewType() {
+ return ItemViewType.STATUS;
}
@Override
- public void onBindViewHolder(NewTabPageViewHolder holder) {
+ protected void onBindViewHolder(NewTabPageViewHolder holder) {
assert holder instanceof StatusCardViewHolder;
((StatusCardViewHolder) holder).onBindViewHolder(this);
}

Powered by Google App Engine
This is Rietveld 408576698