Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3475)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SpacingItem.java

Issue 2396523002: Unify NewTabPageItem and ItemGroup into a single tree-structured interface. (Closed)
Patch Set: review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SpacingItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SpacingItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SpacingItem.java
index 00bf7a30636a0db6785658f3acf4aaef9a2e3914..c4c045d844d369dd1d88817430e7d31705158d86 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SpacingItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SpacingItem.java
@@ -13,7 +13,7 @@ import android.view.ViewGroup;
* contain enough of them. It is displayed as a dummy item with variable height that just occupies
* the remaining space between the last item in the RecyclerView and the bottom of the screen.
*/
-public class SpacingItem extends SingleItemGroup {
+public class SpacingItem extends Leaf {
private static class SpacingView extends View {
public SpacingView(Context context) {
super(context);
@@ -32,12 +32,13 @@ public class SpacingItem extends SingleItemGroup {
}
@Override
- public int getType() {
- return NewTabPageItem.VIEW_TYPE_SPACING;
+ @ItemViewType
+ protected int getItemViewType() {
+ return ItemViewType.SPACING;
}
@Override
- public void onBindViewHolder(NewTabPageViewHolder holder) {
+ protected void onBindViewHolder(NewTabPageViewHolder holder) {
// Nothing to do.
}
}

Powered by Google App Engine
This is Rietveld 408576698