Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Issue 23965009: Document that its the job of the embedder to provide strong entropy for seeding the PRNG. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Document that its the job of the embedder to provide strong entropy for seeding the PRNG. BUG=v8:2905 R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16888

Patch Set 1 #

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/utils/random-number-generator.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/utils/random-number-generator.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
Hey Dmitry, Here's the comment as discussed offline. PTAL -- Benedikt
7 years, 3 months ago (2013-09-23 09:10:55 UTC) #1
Dmitry Lomov (no reviews)
On 2013/09/23 09:10:55, Benedikt Meurer wrote: > Hey Dmitry, > Here's the comment as discussed ...
7 years, 3 months ago (2013-09-23 09:30:31 UTC) #2
Benedikt Meurer
On 2013/09/23 09:30:31, Dmitry Lomov (chromium) wrote: > On 2013/09/23 09:10:55, Benedikt Meurer wrote: > ...
7 years, 3 months ago (2013-09-23 09:56:40 UTC) #3
Dmitry Lomov (no reviews)
lgtm
7 years, 3 months ago (2013-09-23 12:25:24 UTC) #4
Benedikt Meurer
7 years, 3 months ago (2013-09-23 14:11:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r16888 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698