Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1621)

Issue 23965004: Revert 222090 "<webview>: Cleanup WebRequest event listeners whe..." (Closed)

Created:
7 years, 3 months ago by please use gerrit instead
Modified:
7 years, 3 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 222090 "<webview>: Cleanup WebRequest event listeners whe..." Browser test WebViewTest.Shim_TestWebRequestListenerSurvivesReparenting failed on win xp: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%283%29/builds/24239 > <webview>: Cleanup WebRequest event listeners when embedder destroyed > > <webivew> WebRequest event listeners should survive reparenting of the <webview> within the same embedder WebContents. Currently, event listeners are lost when the <webview> is removed from the DOM. This CL solves this problem. > > Note that there is still a problem where custom elements break if the original page that created the element is closed. I have written a test that exercises this problem and I've left the test disabled until we fix the problem. > > BUG=281551 > Test=WebViewTest.Shim_TestWebRequestListenerSurvivesReparenting > > Review URL: https://chromiumcodereview.appspot.com/23514016 TBR=fsamuel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -216 lines) Patch
M trunk/src/chrome/browser/apps/web_view_browsertest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/apps/web_view_interactive_browsertest.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/web_request/web_request_api.h View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/web_request/web_request_api.cc View 8 chunks +11 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 8 chunks +25 lines, -21 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_renderer_state.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/guestview/guestview.h View 2 chunks +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/guestview/guestview.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/guestview/webview/webview_guest.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/guestview/webview/webview_guest.cc View 4 chunks +19 lines, -20 lines 0 comments Download
M trunk/src/chrome/chrome_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/renderer/extensions/dispatcher.cc View 2 chunks +0 lines, -3 lines 0 comments Download
D trunk/src/chrome/renderer/extensions/webview_custom_bindings.h View 1 chunk +0 lines, -25 lines 0 comments Download
D trunk/src/chrome/renderer/extensions/webview_custom_bindings.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M trunk/src/chrome/renderer/resources/extensions/web_view.js View 3 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/test/data/extensions/platform_apps/web_view/newwindow/embedder.js View 4 chunks +1 line, -44 lines 0 comments Download
M trunk/src/chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 2 chunks +19 lines, -36 lines 0 comments Download
M trunk/src/content/browser/browser_plugin/browser_plugin_guest.h View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M trunk/src/content/public/browser/browser_plugin_guest_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
please use gerrit instead
7 years, 3 months ago (2013-09-09 23:12:31 UTC) #1
please use gerrit instead
7 years, 3 months ago (2013-09-09 23:14:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r222123.

Powered by Google App Engine
This is Rietveld 408576698