Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: trunk/src/chrome/renderer/resources/extensions/web_view.js

Issue 23965004: Revert 222090 "<webview>: Cleanup WebRequest event listeners whe..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/renderer/resources/extensions/web_view.js
===================================================================
--- trunk/src/chrome/renderer/resources/extensions/web_view.js (revision 222122)
+++ trunk/src/chrome/renderer/resources/extensions/web_view.js (working copy)
@@ -16,7 +16,6 @@
var WebRequestSchema =
requireNative('schema_registry').GetSchema('webRequest');
var WebView = require('binding').Binding.create('webview').generate();
-var WebViewNatives = requireNative('webview_natives');
// This secret enables hiding <webview> private members from the outside scope.
// Outside of this file, |secret| is inaccessible. The only way to access the
@@ -41,6 +40,8 @@
WEB_VIEW_ATTRIBUTE_MAXWIDTH
];
+var webViewInstanceIdCounter = 0;
+
var CreateEvent = function(name) {
var eventOpts = {supportsListeners: true, supportsFilters: true};
return new EventBindings.Event(name, undefined, eventOpts);
@@ -550,7 +551,7 @@
*/
WebViewInternal.prototype.setupWebviewNodeEvents_ = function() {
var self = this;
- this.viewInstanceId_ = WebViewNatives.GetNextInstanceID();
+ this.viewInstanceId_ = ++webViewInstanceIdCounter;
var onInstanceIdAllocated = function(e) {
var detail = e.detail ? JSON.parse(e.detail) : {};
self.instanceId_ = detail.windowId;

Powered by Google App Engine
This is Rietveld 408576698