Improve the TestNavigationManager

Improve the TestNavigationManager

This CL refactors the TestNavigationManager to make it easier to
understand following the introduction of a new state in
https://codereview.chromium.org/2383773002/.

BUG=651503
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/19f0d4912d3e7518def06bf5579a70029506fb18
Cr-Commit-Position: refs/heads/master@{#425062}

[clamy, 2016-10-04 13:44:16]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 13:44:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 14:05:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 14:05:06]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[clamy, 2016-10-05 15:54:31]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 15:55:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 16:48:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 16:48:03]

Dry run: This issue passed the CQ dry run.

[clamy, 2016-10-12 12:26:19]

Description was changed from

==========
Improve the TestNavigationManager

This CL refactors the TestNavigationManager to make it easier to
understand following the introduction of a new state in
https://codereview.chromium.org/2383773002/.

BUG=651503
==========

to

==========
Improve the TestNavigationManager

This CL refactors the TestNavigationManager to make it easier to
understand following the introduction of a new state in
https://codereview.chromium.org/2383773002/.

BUG=651503
==========

[clamy, 2016-10-12 12:26:20]

clamy@chromium.org changed reviewers:
+ nasko@chromium.org

[clamy, 2016-10-12 12:27:09]

@nasko: PTAL. This is a followup on the CrossSiteResourceHandler merge, to
improve the test code.

[nasko, 2016-10-12 23:53:59]

Thanks for simplifying this! LGTM with a nit.

https://codereview.chromium.org/2396493002/diff/20001/content/public/test/bro...
File content/public/test/browser_test_utils.h (right):

https://codereview.chromium.org/2396493002/diff/20001/content/public/test/bro...
content/public/test/browser_test_utils.h:615: WARN_UNUSED_RESULT bool
WaitForWillStartRequest();
nit: WaitForStartRequest or WaitForRequestStart.

[clamy, 2016-10-13 15:48:51]

Description was changed from

==========
Improve the TestNavigationManager

This CL refactors the TestNavigationManager to make it easier to
understand following the introduction of a new state in
https://codereview.chromium.org/2383773002/.

BUG=651503
==========

to

==========
Improve the TestNavigationManager

This CL refactors the TestNavigationManager to make it easier to
understand following the introduction of a new state in
https://codereview.chromium.org/2383773002/.

BUG=651503
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2016-10-13 15:49:33]

Description was changed from

==========
Improve the TestNavigationManager

This CL refactors the TestNavigationManager to make it easier to
understand following the introduction of a new state in
https://codereview.chromium.org/2383773002/.

BUG=651503
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Improve the TestNavigationManager

This CL refactors the TestNavigationManager to make it easier to
understand following the introduction of a new state in
https://codereview.chromium.org/2383773002/.

BUG=651503
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2016-10-13 15:49:33]

clamy@chromium.org changed reviewers:
+ csharrison@chromium.org

[clamy, 2016-10-13 15:51:55]

Thanks!
@csharrison: PTAL at the changes in chrome/browser/page_load_metrics/.

https://codereview.chromium.org/2396493002/diff/20001/content/public/test/bro...
File content/public/test/browser_test_utils.h (right):

https://codereview.chromium.org/2396493002/diff/20001/content/public/test/bro...
content/public/test/browser_test_utils.h:615: WARN_UNUSED_RESULT bool
WaitForWillStartRequest();
On 2016/10/12 23:53:58, nasko (slow) wrote:
> nit: WaitForStartRequest or WaitForRequestStart.

Done.

[clamy, 2016-10-13 15:52:07]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 15:52:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-10-13 15:56:04]

LGTM!!

[commit-bot: I haz the power, 2016-10-13 16:45:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 16:45:22]

Dry run: This issue passed the CQ dry run.

[clamy, 2016-10-13 16:47:13]

The CQ bit was checked by clamy@chromium.org

[clamy, 2016-10-13 16:47:13]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2396493002/#ps40001
(title: "Addressed Nasko's nit")

[commit-bot: I haz the power, 2016-10-13 16:47:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 16:53:52]

Description was changed from

==========
Improve the TestNavigationManager

This CL refactors the TestNavigationManager to make it easier to
understand following the introduction of a new state in
https://codereview.chromium.org/2383773002/.

BUG=651503
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Improve the TestNavigationManager

This CL refactors the TestNavigationManager to make it easier to
understand following the introduction of a new state in
https://codereview.chromium.org/2383773002/.

BUG=651503
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-10-13 16:53:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-13 16:57:38]

Description was changed from

==========
Improve the TestNavigationManager

This CL refactors the TestNavigationManager to make it easier to
understand following the introduction of a new state in
https://codereview.chromium.org/2383773002/.

BUG=651503
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Improve the TestNavigationManager

This CL refactors the TestNavigationManager to make it easier to
understand following the introduction of a new state in
https://codereview.chromium.org/2383773002/.

BUG=651503
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/19f0d4912d3e7518def06bf5579a70029506fb18
Cr-Commit-Position: refs/heads/master@{#425062}
==========

[commit-bot: I haz the power, 2016-10-13 16:57:39]

Patchset 3 (id:??) landed as
https://crrev.com/19f0d4912d3e7518def06bf5579a70029506fb18
Cr-Commit-Position: refs/heads/master@{#425062}